cmd/compile: Value live at entry

[DrJosh9000]

What version of Go are you using (go version)?

$ go version
go version go1.19.1 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/josh/Library/Caches/go-build"
GOENV="/Users/josh/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/josh/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/josh/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.19.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/josh/Code/adventofcode/go.mod"
GOWORK="/Users/josh/Code/adventofcode/go.work"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/nd/p9vyzdbj1r1_1_wpyd3k_lvr0000gn/T/go-build4128977174=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

https://go.dev/play/p/LgwHMT5v_EV

What did you expect to see?

Compile without error.

What did you see instead?

./prog.go:12:19: internal compiler error: 'Set[go.shape.int_0].Copy': Value live at entry. It shouldn't be. func Set[go.shape.int_0].Copy, node .dict0, value nil

Please file a bug report including a short program that triggers the error.
https://go.dev/issue/new

Go build failed.

[cuonglm]

Duplicated of #53702, are fixed at tip and backported to go1.18. go1.19

[DrJosh9000]

The backport on that issue has milestone 1.19.1, which is the version I'm on, so either the backport is incomplete or this is a separate bug.

[cuonglm]

The backport on that issue has milestone 1.19.1, which is the version I'm on, so either the backport is incomplete or this is a separate bug.

go1.19.1 is a security release, so it's likely not include the backport.

cc @golang/release

[cuonglm]

The backport on that issue has milestone 1.19.1, which is the version I'm on, so either the backport is incomplete or this is a separate bug.

go1.19.1 is a security release, so it's likely not include the backport.

cc @golang/release

Hmm, wait, I see the fix in go1.19.1: https://github.com/golang/go/commits/go1.19.1

Seems strange, on tip, it compiles ok in non-unified IR

go tool compile -d=unified=0 -p=main main.go

[cuonglm]

So #53702 is the issue with non-generic, this is about generic.

Surprisingly, https://go-review.googlesource.com/c/go/+/422196 fixes it.

Should we backport that fix? cc @mdempsky @randall77

[mdempsky]

Yeah, I think CL 422196 is safe to backport if it fixes a regression in 1.19.

[gopherbot]

Change https://go.dev/cl/428758 mentions this issue: test: add regression test for issue 54911

[cuonglm]

@gopherbot please backport this to go1.19

[gopherbot]

Backport issue(s) opened: #54917 (for 1.19).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

[cuonglm]

@gopherbot please backport this to go1.18