Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: extra RemoveDep #5502

Closed
gopherbot opened this issue May 17, 2013 · 3 comments
Closed

database/sql: extra RemoveDep #5502

gopherbot opened this issue May 17, 2013 · 3 comments
Assignees

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 17, 2013

by KevinCathcart:

Bradfitz forgot to remove the `s.db.removeDep(v.dc, s)` line as part of changeset
45c12efb4635, which removed the corresponding addDep call.

This bug was added per his request. See
https://groups.google.com/d/msg/golang-nuts/A_MEp3wOEnY/voBh6A9WYvYJ

This is very minor, causing no harm beyond the limited perfomance hit, but should still
be corrected.
@minux
Copy link
Member

@minux minux commented May 17, 2013

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Owner changed to @bradfitz.

Status changed to Accepted.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 18, 2013

Comment 2:

Mailed https://golang.org/cl/9543043

Status changed to Started.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 21, 2013

Comment 3:

This issue was closed by revision 0e10196.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.