Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestMemStats failure with insanely high value on openbsd-amd64-68 #55065

Open
bcmills opened this issue Sep 14, 2022 · 2 comments
Open
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Sep 14, 2022

#!watchflakes
post <- pkg == "runtime" && test == "TestMemStats" && `insanely high value`
##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
--- FAIL: TestMemStats (0.00s)
    malloc_test.go:93: PauseTotalNs = 18446744073177999286: insanely high value (overflow?); want <= 1e+11
FAIL
FAIL	runtime	21.088s

greplogs -l -e 'FAIL: TestMemStats.*(?:\n\s+.*)*insanely high value' --since=2022-01-01
2022-09-09T01:04:57-76c94eb/openbsd-amd64-68

attn @golang/openbsd; CC @golang/runtime

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 14, 2022
@bcmills bcmills added this to the Backlog milestone Sep 14, 2022
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed compiler/runtime Issues related to the Go compiler and/or runtime. labels Sep 14, 2022
@mknyszek
Copy link
Contributor

mknyszek commented Sep 14, 2022

... We should really update that error message.

I'm going to guess this is a product of the fact that OpenBSD has coarse-grained timers. As the error message suggests, this looks to me like a negative duration (note PauseTotalNs is a uint64, so the int64 nanotime result is cast first).

I guess the fix is to defensively check for a negative duration and clamp at zero?

@gopherbot
Copy link

gopherbot commented Sep 20, 2022

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestMemStats" && `insanely high value`
2022-09-09 01:04 openbsd-amd64-68 go@76c94eb7 runtime.TestMemStats (log)
--- FAIL: TestMemStats (0.00s)
    malloc_test.go:93: PauseTotalNs = 18446744073177999286: insanely high value (overflow?); want <= 1e+11

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Projects
Status: Active
Development

No branches or pull requests

3 participants