Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestVDSO failures due to hang or crash in SignalInVDSO since 2022-09-02 #55073

Closed
bcmills opened this issue Sep 14, 2022 · 3 comments
Closed
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Sep 14, 2022

greplogs -l -e 'FAIL: TestVDSO.*(?:\n\s+.*)*testprog\.exe SignalInVDSO' --since=2022-01-01
2022-09-06T15:49:30-c35bc69/darwin-arm64-11

--- FAIL: TestVDSO (60.02s)
    testenv.go:468: [/tmp/buildlet/tmp/go-build1960920154/testprog.exe SignalInVDSO] exit status: exit status 2
    crash_test.go:144: output:
        SIGQUIT: quit
        PC=0x182fa8304 m=1 sigcode=0
        
…        
        goroutine 1 [runnable]:
        time.Time.Sub({0xc0bdf955c4d64fd0, 0x17f57176, 0x1004d19c0}, {0xc0bdf955a87e4d70, 0x29a82, 0x1004d19c0})
        	/tmp/buildlet/go/src/time/time.go:863 +0x18c fp=0x1400006ee40 sp=0x1400006ee40 pc=0x10039bb5c
        main.signalInVDSO()
        	/private/tmp/buildlet/go/src/runtime/testdata/testprog/vdso.go:36 +0x114 fp=0x1400006eed0 sp=0x1400006ee40 pc=0x1003e4654
        main.main()
        	/private/tmp/buildlet/go/src/runtime/testdata/testprog/main.go:34 +0x120 fp=0x1400006ef70 sp=0x1400006eed0 pc=0x1003e0dd0
        runtime.main()
        	/tmp/buildlet/go/src/runtime/proc.go:250 +0x248 fp=0x1400006efd0 sp=0x1400006ef70 pc=0x10035d9e8
        runtime.goexit()
        	/tmp/buildlet/go/src/runtime/asm_arm64.s:1172 +0x4 fp=0x1400006efd0 sp=0x1400006efd0 pc=0x10038ab94

2022-09-06T15:48:16-07b19bf/linux-386-longtest

##### maymorestack=mayMoreStackPreempt
--- FAIL: TestVDSO (0.15s)
    testenv.go:468: [/workdir/tmp/go-build2315874385/testprog.exe SignalInVDSO] exit status: signal: segmentation fault (core dumped)
    crash_test.go:144: output:
        
        
        wanted:
        success
FAIL
FAIL	runtime	95.444s

2022-09-06T15:44:28-32f68b5/linux-386-longtest
2022-09-05T21:39:28-4c1ca42/linux-386-longtest
2022-09-05T08:28:34-bd5595d/linux-386-longtest
2022-09-05T08:08:24-af7f417/linux-386-longtest
2022-09-05T08:08:18-4ad55cd/linux-386-longtest
2022-09-05T08:07:47-357b922/linux-386-longtest
2022-09-05T07:17:56-4e7e7ae/linux-386-longtest
2022-09-05T07:14:08-3fbcf05/linux-386-longtest
2022-09-04T04:17:04-535fe2b/linux-386-longtest
2022-09-03T18:21:45-a0f0582/linux-386-longtest
2022-09-03T15:45:36-f798dc6/linux-386-longtest
2022-09-02T19:22:26-0fda8b1/linux-386-longtest
2022-09-02T19:09:03-55ca6a2/linux-386-longtest
2022-09-02T19:08:56-b91e373/linux-386-longtest
2022-09-02T19:08:53-dbf442b/linux-386-longtest

(attn @golang/runtime)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Sep 14, 2022
@bcmills bcmills added this to the Go1.20 milestone Sep 14, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 14, 2022
@bcmills
Copy link
Member Author

bcmills commented Sep 14, 2022

This may be related to #54778.

@bcmills
Copy link
Member Author

bcmills commented Sep 14, 2022

This may also have been fixed by #54885? (Not clear to me whether that issue explains the hang in the test on darwin/arm64.)

@aclements
Copy link
Member

aclements commented Sep 21, 2022

No new occurrences since 2022-09-06T15:49:30-c35bc69/darwin-arm64-11, which I think is strong enough evidence that this was a dup of #54885, which has been fixed.

@aclements aclements closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Status: Done
Development

No branches or pull requests

3 participants