Skip to content

proposal: hash: permit usage of encoding/binary package #55104

@ErikPelli

Description

@ErikPelli

In the pull request #55068 it turned out that the package hash must not depend on encoding/binary.
In my opinion, if this was allowed, the code would be cleaner (I recommend to see the proposed changes in the PR) and the practical difference would not be much, since encoding/binary has little code in it that does what is needed.

Furthermore, this package is already used as a replacement for the append/put uint32/64 functions in the crypto package.
I therefore propose to allow the use of encoding/binary also in the hash package and avoid code duplication.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions