Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: new darwin linker warning on -pagezero_size and -no_pie deprecation [1.18 backport] #55113

Closed
gopherbot opened this issue Sep 16, 2022 · 3 comments
Assignees
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Sep 16, 2022

@cherrymui requested issue #55112 to be considered for backport to the next 1.18 minor release.

@gopherbot please backport this to previous releases. Thanks.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 16, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 16, 2022
@gopherbot gopherbot added this to the Go1.18.7 milestone Sep 16, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 16, 2022

Change https://go.dev/cl/431516 mentions this issue: [release-branch.go1.18] cmd/link: stop passing -pagezero_size to darwin linker

@gopherbot
Copy link
Author

gopherbot commented Sep 16, 2022

Change https://go.dev/cl/431518 mentions this issue: [release-branch.go1.18] cmd/link: suppress -no_pie deprecation warning on darwin

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Sep 21, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 21, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 21, 2022

Closed by merging c8e1cf4 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Sep 21, 2022
…in linker

We added -pagezero_size in CL 72730, where it was intented for iOS.
The current code passes it only on macOS/AMD64 instead. It is not
really necessary there. Also, the new darwin linker starts to emit
a warning about deprecation of the flag. Stop passing it.

For #55113
Updates #54482, #55112.

Change-Id: If9db7a1645c37d4284e48f075856912df8d8c1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/430936
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 5231ba2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431516
Reviewed-by: Austin Clements <austin@google.com>
gopherbot pushed a commit that referenced this issue Sep 21, 2022
…g on darwin

Apparently the new darwin linker starts to emit a warning about
-no_pie deprecation. Maybe we want to switch to PIE by default.
For now, suppress the warning. This also makes it easier for
backporting to previous releases.

Fixes #55113.
Updates #55112, #54482.

Change-Id: I1a3b74c237a9d00ec3b030fc3a9940a31e5cd37e
Reviewed-on: https://go-review.googlesource.com/c/go/+/430937
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 706d84f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431518
Reviewed-by: Austin Clements <austin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
Status: Done
Development

No branches or pull requests

3 participants