Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/jsonrpc2: TestIdleTimeout failures #55179

Open
gopherbot opened this issue Sep 20, 2022 · 66 comments
Open

x/tools/internal/jsonrpc2: TestIdleTimeout failures #55179

gopherbot opened this issue Sep 20, 2022 · 66 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Contributor Author

gopherbot commented Sep 20, 2022 •
edited by rsc
Loading

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-07-22 16:51 openbsd-386-68 tools@7b605f47 go@12e00f6c x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.33s)
panic: dial tcp 127.0.0.1:29124: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:29124: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81c8080, 0x60010360})
	/tmp/workdir/go/src/testing/testing.go:1389 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1392 +0x419
panic({0x81c8080, 0x60010360})
	/tmp/workdir/go/src/runtime/panic.go:838 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x600011d0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x2e8
testing.tRunner(0x600011d0, 0x81e7cc8)
	/tmp/workdir/go/src/testing/testing.go:1439 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1486 +0x36e
2022-07-25 19:36 freebsd-arm64-dmgk tools@2a6393fe go@ed50277f x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.48s)
panic: dial tcp 127.0.0.1:59285: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:59285: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x196120, 0x4000012230})
	/tmp/workdir-host-freebsd-arm64-dmgk/go/src/testing/testing.go:1389 +0x1c8
testing.tRunner.func1()
	/tmp/workdir-host-freebsd-arm64-dmgk/go/src/testing/testing.go:1392 +0x380
panic({0x196120, 0x4000012230})
	/tmp/workdir-host-freebsd-arm64-dmgk/go/src/runtime/panic.go:838 +0x20c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir-host-freebsd-arm64-dmgk/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x80
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x4000087860)
	/tmp/workdir-host-freebsd-arm64-dmgk/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x2a4
testing.tRunner(0x4000087860, 0x1c6628)
	/tmp/workdir-host-freebsd-arm64-dmgk/go/src/testing/testing.go:1439 +0x110
created by testing.(*T).Run
	/tmp/workdir-host-freebsd-arm64-dmgk/go/src/testing/testing.go:1486 +0x328
2022-08-10 17:41 openbsd-amd64-68 tools@0ad49fde go@522f0fc4 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.81s)
panic: dial tcp 127.0.0.1:28196: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:28196: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x598100, 0xc000016690})
	/tmp/workdir/go/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1399 +0x39f
panic({0x598100, 0xc000016690})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x212
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x6c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc00011e680)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x315
testing.tRunner(0xc00011e680, 0x5c9648)
	/tmp/workdir/go/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1493 +0x35f
2022-08-15 18:38 openbsd-amd64-68 tools@8c830569 go@8ec1aa88 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.53s)
panic: dial tcp 127.0.0.1:27165: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:27165: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x599380, 0xc000410000})
	/tmp/workdir/go/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1399 +0x39f
panic({0x599380, 0xc000410000})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x212
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x6c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc000106d00)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x315
testing.tRunner(0xc000106d00, 0x5caac8)
	/tmp/workdir/go/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1493 +0x35f
2022-09-02 19:58 openbsd-386-70 tools@d815cba5 go@9fc09d2f x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.56s)
panic: dial tcp 127.0.0.1:19319: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:19319: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d0c40, 0x6b39e000})
	/tmp/workdir/go/src/testing/testing.go:1429 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1432 +0x42a
panic({0x81d0c40, 0x6b39e000})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b8
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x6b0070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33e
testing.tRunner(0x6b0070e0, 0x81f0da4)
	/tmp/workdir/go/src/testing/testing.go:1479 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1526 +0x373
2022-09-09 18:15 linux-ppc64-buildlet tools@0eebaabc go@31d06b58 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.57s)
panic: dial tcp 127.0.0.1:43354: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:43354: connect: connection refused

goroutine 18 [running]:
testing.tRunner.func1.2({0x1a4780, 0xc00009c690})
	/workdir/go/src/testing/testing.go:1389 +0x1fc
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1392 +0x364
panic({0x1a4780, 0xc00009c690})
	/workdir/go/src/runtime/panic.go:838 +0x240
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x90
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc000099380)
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x26c
testing.tRunner(0xc000099380, 0x1d4820)
	/workdir/go/src/testing/testing.go:1439 +0x11c
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1486 +0x36c
2022-09-13 15:21 openbsd-386-70 tools@9250e22a go@19d792c1 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.60s)
panic: dial tcp 127.0.0.1:6953: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:6953: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x81cf4a0, 0x77816060})
	/tmp/workdir/go/src/testing/testing.go:1396 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1399 +0x419
panic({0x81cf4a0, 0x77816060})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x778825a0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33a
testing.tRunner(0x778825a0, 0x81ef210)
	/tmp/workdir/go/src/testing/testing.go:1446 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1493 +0x36e

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc rsc moved this to Active in Test Flakes Sep 20, 2022
@gopherbot gopherbot changed the title x/tools/internal/jsonrpc2: flaky TestIdleTimeout x/tools/internal/jsonrpc2: TestIdleTimeout failures Sep 20, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-09-22 21:09 openbsd-386-68 tools@62ae5861 go@533cd803 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.89s)
panic: dial tcp 127.0.0.1:25452: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:25452: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d6e20, 0x65016390})
	/tmp/workdir/go/src/testing/testing.go:1431 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1434 +0x42a
panic({0x81d6e20, 0x65016390})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x650070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x2ec
testing.tRunner(0x650070e0, 0x81f7ef8)
	/tmp/workdir/go/src/testing/testing.go:1481 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1528 +0x373

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-09-29 22:28 openbsd-amd64-68 tools@d49f960b go@a14ac863 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.62s)
panic: dial tcp 127.0.0.1:49072: connect: connection reset by peer [recovered]
	panic: dial tcp 127.0.0.1:49072: connect: connection reset by peer

goroutine 19 [running]:
testing.tRunner.func1.2({0x59ca80, 0xc000094190})
	/tmp/workdir/go/src/testing/testing.go:1451 +0x24e
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1454 +0x39f
panic({0x59ca80, 0xc000094190})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x213
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x6c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc000106d00)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x31a
testing.tRunner(0xc000106d00, 0x5cfb20)
	/tmp/workdir/go/src/testing/testing.go:1501 +0x10b
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1548 +0x35f
2022-09-30 19:58 openbsd-386-68 tools@3e0355b8 go@9d2c73a9 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (1.27s)
panic: dial tcp 127.0.0.1:41872: connect: connection reset by peer [recovered]
	panic: dial tcp 127.0.0.1:41872: connect: connection reset by peer

goroutine 19 [running]:
testing.tRunner.func1.2({0x81c8080, 0x625003c0})
	/tmp/workdir/go/src/testing/testing.go:1389 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1392 +0x419
panic({0x81c8080, 0x625003c0})
	/tmp/workdir/go/src/runtime/panic.go:838 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x625063c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33a
testing.tRunner(0x625063c0, 0x81e7cc8)
	/tmp/workdir/go/src/testing/testing.go:1439 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1486 +0x36e

— watchflakes

@bcmills bcmills self-assigned this Oct 4, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-10-05 16:05 openbsd-386-68 tools@2d32e152 go@97d38f30 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.55s)
panic: dial tcp 127.0.0.1:11154: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:11154: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d6ca0, 0x5fb280c0})
	/tmp/workdir/go/src/testing/testing.go:1451 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1454 +0x42a
panic({0x81d6ca0, 0x5fb280c0})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x5f8070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33e
testing.tRunner(0x5f8070e0, 0x81f7fb4)
	/tmp/workdir/go/src/testing/testing.go:1501 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1548 +0x379

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-10-17 17:58 openbsd-amd64-70 tools@bc4e384f go@3e100a22 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.35s)
panic: dial tcp 127.0.0.1:18442: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:18442: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x59c940, 0xc0003a2050})
	/tmp/workdir/go/src/testing/testing.go:1451 +0x24e
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1454 +0x39f
panic({0x59c940, 0xc0003a2050})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x213
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x6c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc00012c4e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x2c2
testing.tRunner(0xc00012c4e0, 0x5cff98)
	/tmp/workdir/go/src/testing/testing.go:1501 +0x10b
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1548 +0x35f

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-10-17 20:15 openbsd-386-70 tools@b2efd4d1 go@07c57aff x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.71s)
panic: dial tcp 127.0.0.1:31596: connect: connection reset by peer [recovered]
	panic: dial tcp 127.0.0.1:31596: connect: connection reset by peer

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d6f00, 0x57004000})
	/tmp/workdir/go/src/testing/testing.go:1451 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1454 +0x42a
panic({0x81d6f00, 0x57004000})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x56c070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33e
testing.tRunner(0x56c070e0, 0x81f8808)
	/tmp/workdir/go/src/testing/testing.go:1501 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1548 +0x379

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-10-18 15:43 windows-arm64-10 tools@a9b653b4 go@947091d3 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (2.89s)
panic: dial tcp 127.0.0.1:49911: connectex: No connection could be made because the target machine actively refused it. [recovered]
	panic: dial tcp 127.0.0.1:49911: connectex: No connection could be made because the target machine actively refused it.

goroutine 6 [running]:
testing.tRunner.func1.2({0x7ff6c767c0c0, 0x4000058460})
	C:/workdir/go/src/testing/testing.go:1389 +0x1c8
testing.tRunner.func1()
	C:/workdir/go/src/testing/testing.go:1392 +0x380
panic({0x7ff6c767c0c0, 0x4000058460})
	C:/workdir/go/src/runtime/panic.go:838 +0x20c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	C:/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x80
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x4000146340)
	C:/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x25c
testing.tRunner(0x4000146340, 0x7ff6c76acd60)
	C:/workdir/go/src/testing/testing.go:1439 +0x110
created by testing.(*T).Run
	C:/workdir/go/src/testing/testing.go:1486 +0x328

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-10-18 15:43 openbsd-386-68 tools@a9b653b4 go@7ae652b7 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.67s)
panic: dial tcp 127.0.0.1:47547: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:47547: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d6f00, 0x6d016390})
	/tmp/workdir/go/src/testing/testing.go:1451 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1454 +0x42a
panic({0x81d6f00, 0x6d016390})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x6d0070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33e
testing.tRunner(0x6d0070e0, 0x81f8828)
	/tmp/workdir/go/src/testing/testing.go:1501 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1548 +0x379

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-10-28 20:13 openbsd-386-70 tools@e172e97c go@b726b0ca x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.94s)
panic: dial tcp 127.0.0.1:7740: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:7740: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d9060, 0x6cf12030})
	/tmp/workdir/go/src/testing/testing.go:1506 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1509 +0x42a
panic({0x81d9060, 0x6cf12030})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x6cc070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33e
testing.tRunner(0x6cc070e0, 0x81faaf4)
	/tmp/workdir/go/src/testing/testing.go:1556 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1603 +0x379

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-11-07 21:25 openbsd-386-70 tools@003fde14 go@9860faa5 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (1.75s)
panic: dial tcp 127.0.0.1:9834: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:9834: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81da140, 0x670163c0})
	/tmp/workdir/go/src/testing/testing.go:1519 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1522 +0x42a
panic({0x81da140, 0x670163c0})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x670072c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x2ec
testing.tRunner(0x670072c0, 0x81fbc2c)
	/tmp/workdir/go/src/testing/testing.go:1569 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1618 +0x3f6
2022-11-09 17:16 openbsd-386-68 tools@502c6347 go@a3dce127 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (1.33s)
panic: dial tcp 127.0.0.1:15762: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:15762: connect: connection refused

goroutine 18 [running]:
testing.tRunner.func1.2({0x81c81e0, 0x6dc100f0})
	/tmp/workdir/go/src/testing/testing.go:1389 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1392 +0x419
panic({0x81c81e0, 0x6dc100f0})
	/tmp/workdir/go/src/runtime/panic.go:838 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x6dc822d0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33a
testing.tRunner(0x6dc822d0, 0x81e7ea8)
	/tmp/workdir/go/src/testing/testing.go:1439 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1486 +0x36e
2022-11-11 16:02 openbsd-amd64-70 tools@e3b3c010 go@ed615aaf x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.41s)
panic: dial tcp 127.0.0.1:8954: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:8954: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x5a3ee0, 0xc0000960a0})
	/tmp/workdir/go/src/testing/testing.go:1521 +0x24e
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1524 +0x39f
panic({0x5a3ee0, 0xc0000960a0})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x213
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x6c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc00012a4e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x31a
testing.tRunner(0xc00012a4e0, 0x5d7f38)
	/tmp/workdir/go/src/testing/testing.go:1571 +0x10b
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1620 +0x3df

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-11-17 20:46 openbsd-386-70 tools@dea100b1 go@861ba027 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.44s)
panic: dial tcp 127.0.0.1:24588: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:24588: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x81cf600, 0x73014000})
	/tmp/workdir/go/src/testing/testing.go:1396 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1399 +0x419
panic({0x81cf600, 0x73014000})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x72d063c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33a
testing.tRunner(0x72d063c0, 0x81ef40c)
	/tmp/workdir/go/src/testing/testing.go:1446 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1493 +0x36e
2022-11-18 17:19 openbsd-386-70 tools@c7ed4b3c go@d96e5847 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.67s)
panic: dial tcp 127.0.0.1:32079: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:32079: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81c81e0, 0x67810360})
	/tmp/workdir/go/src/testing/testing.go:1389 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1392 +0x419
panic({0x81c81e0, 0x67810360})
	/tmp/workdir/go/src/runtime/panic.go:838 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x678011d0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33a
testing.tRunner(0x678011d0, 0x81e7ea8)
	/tmp/workdir/go/src/testing/testing.go:1439 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1486 +0x36e
2022-11-18 21:46 openbsd-386-70 tools@19fb30d1 go@831c6509 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.29s)
panic: dial tcp 127.0.0.1:20618: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:20618: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d9600, 0x574940c0})
	/tmp/workdir/go/src/testing/testing.go:1525 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1528 +0x446
panic({0x81d9600, 0x574940c0})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x574070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33f
testing.tRunner(0x574070e0, 0x81fab7c)
	/tmp/workdir/go/src/testing/testing.go:1575 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1628 +0x421

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-11-21 19:26 openbsd-386-68 tools@41c70c91 go@861ba027 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.31s)
panic: dial tcp 127.0.0.1:46660: connect: connection reset by peer [recovered]
	panic: dial tcp 127.0.0.1:46660: connect: connection reset by peer

goroutine 6 [running]:
testing.tRunner.func1.2({0x81cf600, 0x6c796000})
	/tmp/workdir/go/src/testing/testing.go:1396 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1399 +0x419
panic({0x81cf600, 0x6c796000})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x6c406f00)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:51 +0x301
testing.tRunner(0x6c406f00, 0x81ef40c)
	/tmp/workdir/go/src/testing/testing.go:1446 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1493 +0x36e

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-12-02 16:40 linux-ppc64-sid-buildlet tools@25fdb81e go@6ec6492f x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.14s)
panic: dial tcp 127.0.0.1:45789: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:45789: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x1b5bc0, 0xc0003280f0})
	/workdir/go/src/testing/testing.go:1525 +0x1fc
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1528 +0x370
panic({0x1b5bc0, 0xc0003280f0})
	/workdir/go/src/runtime/panic.go:884 +0x240
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x90
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc000003a00)
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x270
testing.tRunner(0xc000003a00, 0x1e7c90)
	/workdir/go/src/testing/testing.go:1575 +0x11c
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1628 +0x3e8

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-12-09 18:48 darwin-amd64-nocgo tools@a310bcb1 go@df5d4d3d x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.20s)
panic: dial tcp 127.0.0.1:49219: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:49219: connect: connection refused

goroutine 18 [running]:
testing.tRunner.func1.2({0x1195160, 0xc000396000})
	/tmp/buildlet/go/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	/tmp/buildlet/go/src/testing/testing.go:1399 +0x39f
panic({0x1195160, 0xc000396000})
	/tmp/buildlet/go/src/runtime/panic.go:884 +0x212
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x6c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc000082d00)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x2bd
testing.tRunner(0xc000082d00, 0x11c5278)
	/tmp/buildlet/go/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	/tmp/buildlet/go/src/testing/testing.go:1493 +0x35f
2022-12-09 18:48 openbsd-386-68 tools@a310bcb1 go@2b989668 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.70s)
panic: dial tcp 127.0.0.1:43820: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:43820: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x81c8200, 0x70810030})
	/tmp/workdir/go/src/testing/testing.go:1389 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1392 +0x419
panic({0x81c8200, 0x70810030})
	/tmp/workdir/go/src/runtime/panic.go:838 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x709025a0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x33a
testing.tRunner(0x709025a0, 0x81e7ef4)
	/tmp/workdir/go/src/testing/testing.go:1439 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1486 +0x36e

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2022-11-29 20:30 openbsd-386-68 tools@7a1b5707 go@53c48007 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.68s)
panic: dial tcp 127.0.0.1:12411: connect: connection reset by peer [recovered]
	panic: dial tcp 127.0.0.1:12411: connect: connection reset by peer

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d9600, 0x57016420})
	/tmp/workdir/go/src/testing/testing.go:1525 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1528 +0x446
panic({0x81d9600, 0x57016420})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x570070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:51 +0x306
testing.tRunner(0x570070e0, 0x81fab7c)
	/tmp/workdir/go/src/testing/testing.go:1575 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1628 +0x421

— watchflakes

@bcmills bcmills modified the milestones: Unreleased, gopls/later Jan 5, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 5, 2023 •
edited
Loading

Discussed with @golang/tools-team.

Our plan to address this is to move gopls to jsonrp2_v2, which has already been cleaned up, and then delete the v1 version of the jsonrpc2 package (along with its known bugs).

But not in the next gopls release; perhaps in the one after that.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-01-17 18:02 openbsd-386-71 tools@8aba49bb go@d74c31f0 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.49s)
panic: dial tcp 127.0.0.1:9538: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:9538: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81d9600, 0x5f404000})
	/tmp/workdir/go/src/testing/testing.go:1526 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1529 +0x446
panic({0x81d9600, 0x5f404000})
	/tmp/workdir/go/src/runtime/panic.go:884 +0x1b4
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x5f0070e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x2ed
testing.tRunner(0x5f0070e0, 0x81fab7c)
	/tmp/workdir/go/src/testing/testing.go:1576 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1629 +0x421

— watchflakes

This was referenced Jan 23, 2023
Open
Open
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-01-19 22:12 dragonfly-amd64-622 tools@ff9bea52 go@e590afcf x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.43s)
panic: dial tcp 127.0.0.1:51152: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:51152: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x5a4800, 0xc000016820})
	/tmp/workdir/go/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1529 +0x39f
panic({0x5a4800?, 0xc000016820?})
	/tmp/workdir/go/src/runtime/panic.go:912 +0x275
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x6c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc0000d0340)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x31a
testing.tRunner(0xc0000d0340, 0x5d8208)
	/tmp/workdir/go/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1629 +0x3ea

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-01-25 23:57 freebsd-386-12_3 tools@82707575 go@581603cb x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.42s)
panic: dial tcp 127.0.0.1:45959: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:45959: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x81ca720, 0x38f8e030})
	/tmp/workdir/go/src/testing/testing.go:1389 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1392 +0x419
panic({0x81ca720, 0x38f8e030})
	/tmp/workdir/go/src/runtime/panic.go:838 +0x1b7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:31 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x38c013b0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:50 +0x2e8
testing.tRunner(0x38c013b0, 0x81e93fc)
	/tmp/workdir/go/src/testing/testing.go:1439 +0x10d
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1486 +0x36e

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-09-28 16:44 openbsd-386-72 tools@4cd12d6d go@a15ef1bb x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.18s)
panic: dial tcp 127.0.0.1:20870: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:20870: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x81e8d60, 0x5ac9c030})
	/tmp/workdir/go/src/testing/testing.go:1545 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1548 +0x438
panic({0x81e8d60, 0x5ac9c030})
	/tmp/workdir/go/src/runtime/panic.go:914 +0x1e0
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x5ad840f0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x2f0
testing.tRunner(0x5ad840f0, 0x820c994)
	/tmp/workdir/go/src/testing/testing.go:1595 +0x11a
created by testing.(*T).Run in goroutine 1
	/tmp/workdir/go/src/testing/testing.go:1648 +0x3d7

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-10-02 08:05 openbsd-386-72 tools@2ed42984 go@a15ef1bb x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.50s)
panic: dial tcp 127.0.0.1:46874: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:46874: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x81e8d60, 0x63816060})
	/tmp/workdir/go/src/testing/testing.go:1545 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1548 +0x438
panic({0x81e8d60, 0x63816060})
	/tmp/workdir/go/src/runtime/panic.go:914 +0x1e0
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x9e
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x6390c0f0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:53 +0x2d7
testing.tRunner(0x6390c0f0, 0x820c994)
	/tmp/workdir/go/src/testing/testing.go:1595 +0x11a
created by testing.(*T).Run in goroutine 1
	/tmp/workdir/go/src/testing/testing.go:1648 +0x3d7

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-10-08 02:08 freebsd-riscv64-unmatched tools@a3b5082f go@2744155d x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.37s)
panic: dial tcp 127.0.0.1:22701: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:22701: connect: connection refused

goroutine 22 [running]:
testing.tRunner.func1.2({0x1aab80, 0x8809a9b0})
	/tmp/workdir-host-freebsd-riscv64-unmatched/go/src/testing/testing.go:1543 +0x1e0
testing.tRunner.func1()
	/tmp/workdir-host-freebsd-riscv64-unmatched/go/src/testing/testing.go:1546 +0x2ec
panic({0x1aab80?, 0x8809a9b0?})
	/tmp/workdir-host-freebsd-riscv64-unmatched/go/src/runtime/panic.go:765 +0x108
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x80
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x88085380)
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x248
testing.tRunner(0x88085380, 0x1e0860)
	/tmp/workdir-host-freebsd-riscv64-unmatched/go/src/testing/testing.go:1593 +0x104
created by testing.(*T).Run in goroutine 1
	/tmp/workdir-host-freebsd-riscv64-unmatched/go/src/testing/testing.go:1646 +0x348

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-10-26 17:36 openbsd-386-72 tools@ff1953bd go@7546c79e x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.55s)
panic: dial tcp 127.0.0.1:46341: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:46341: connect: connection refused

goroutine 5 [running]:
testing.tRunner.func1.2({0x81ebfc0, 0x5e0163c0})
	/tmp/workdir/go/src/testing/testing.go:1631 +0x29d
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1634 +0x42e
panic({0x81ebfc0, 0x5e0163c0})
	/tmp/workdir/go/src/runtime/panic.go:763 +0xf7
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x98
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x5e007300)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x2b0
testing.tRunner(0x5e007300, 0x820f5ec)
	/tmp/workdir/go/src/testing/testing.go:1682 +0x11f
created by testing.(*T).Run in goroutine 1
	/tmp/workdir/go/src/testing/testing.go:1735 +0x3b3

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-11-29 14:56 darwin-amd64-10_15 tools@6e052bb7 go@6111acc8 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.26s)
panic: dial tcp 127.0.0.1:49547: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:49547: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x80aa5c0, 0xc0000ba7d0})
	/tmp/buildlet/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/tmp/buildlet/go/src/testing/testing.go:1634 +0x377
panic({0x80aa5c0?, 0xc0000ba7d0?})
	/tmp/buildlet/go/src/runtime/panic.go:770 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc000082ea0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:53 +0x28e
testing.tRunner(0xc000082ea0, 0x80d2fc0)
	/tmp/buildlet/go/src/testing/testing.go:1682 +0xfb
created by testing.(*T).Run in goroutine 1
	/tmp/buildlet/go/src/testing/testing.go:1735 +0x390

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-12-11 15:18 darwin-amd64-12_0 tools@7590aeb2 go@bbab863a x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.23s)
panic: dial tcp 127.0.0.1:49228: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:49228: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x11a4c60, 0xc000394000})
	/tmp/buildlet/go/src/testing/testing.go:1545 +0x238
testing.tRunner.func1()
	/tmp/buildlet/go/src/testing/testing.go:1548 +0x397
panic({0x11a4c60?, 0xc000394000?})
	/tmp/buildlet/go/src/runtime/panic.go:914 +0x21f
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc00015e340)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:53 +0x2be
testing.tRunner(0xc00015e340, 0x11da718)
	/tmp/buildlet/go/src/testing/testing.go:1595 +0xff
created by testing.(*T).Run in goroutine 1
	/tmp/buildlet/go/src/testing/testing.go:1648 +0x3ad

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2023-12-12 16:25 darwin-arm64-11 tools@8bd7553f go@e70d3433 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (122.27s)
    serve_test.go:63: run() returned error <nil>, want timed out waiting for new connections

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-01-08 23:16 windows-amd64-longtest tools@c95fa0ff go@b702e043 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.85s)
panic: dial tcp 127.0.0.1:49716: connectex: No connection could be made because the target machine actively refused it. [recovered]
	panic: dial tcp 127.0.0.1:49716: connectex: No connection could be made because the target machine actively refused it.

goroutine 6 [running]:
testing.tRunner.func1.2({0x13c8f40, 0xc000384000})
	C:/workdir/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	C:/workdir/go/src/testing/testing.go:1634 +0x377
panic({0x13c8f40?, 0xc000384000?})
	C:/workdir/go/src/runtime/panic.go:770 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	C:/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc0001304e0)
	C:/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:53 +0x28e
testing.tRunner(0xc0001304e0, 0x14020a0)
	C:/workdir/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	C:/workdir/go/src/testing/testing.go:1742 +0x390

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-01-22 17:11 darwin-arm64-12 tools@a987ef7a go@d29980cd x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (60.00s)
    serve_test.go:63: run() returned error <nil>, want timed out waiting for new connections

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-02-08 13:20 x_tools-gotip-darwin-arm64_12 tools@f4fa7a75 go@643d816c x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
    serve_test.go:63: run() returned error <nil>, want timed out waiting for new connections
--- FAIL: TestIdleTimeout (60.10s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-02-22 18:17 darwin-amd64-nocgo tools@054c06df go@db57e5a0 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.25s)
panic: dial tcp 127.0.0.1:49220: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:49220: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x1c516e0, 0xc000014870})
	/tmp/buildlet/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/tmp/buildlet/go/src/testing/testing.go:1634 +0x377
panic({0x1c516e0?, 0xc000014870?})
	/tmp/buildlet/go/src/runtime/panic.go:759 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc00007e680)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:53 +0x28e
testing.tRunner(0xc00007e680, 0x1c7a460)
	/tmp/buildlet/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	/tmp/buildlet/go/src/testing/testing.go:1742 +0x390

— watchflakes

@bcmills bcmills removed their assignment Mar 11, 2024
@bcmills
Copy link
Contributor

bcmills commented Mar 11, 2024 •
edited
Loading

Marking this as NeedsFix. The fix it needs is for gopls to migrate to jsonrpc2_v2 so we can delete x/tools/internal/jsonrpc2 completely.

(CC @findleyr @adonovan)

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 11, 2024
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 11, 2024
@adonovan
Copy link
Member

How confident are we that the new "better" RPC stack is an improvement over the old "debugged" one? I can imagine all kinds of theoretical advantages it might have, but rarely is the RPC stack the cause of any problem in gopls, at least to my knowledge.

@bcmills
Copy link
Contributor

bcmills commented Mar 11, 2024

Well, the new one passes its tests reliably, and the old one doesn't. 😅

The alternative would be to backport (some subset of) the fixes from #46047 from jsonrpc2_v2 to jsonrpc2 — but those backports are non-trivial due to implementation differences. (That's why I didn't already do them.)

@ianthehat
Copy link

The old jsonrpc system has a lot of problems, not least of which is that cancellation is fundamentally broken. I would much rather have fixed it in place, but it was not feasible to do so, the API essentially forced a broken mode of behavior on you.
When I wrote it I was very very confident it would not only be better but fix a bunch of open issues, but after 3 years I no longer remember what all those issues were or why we did not switch at the time.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-03-11 20:13 darwin-amd64-longtest tools@ca94c966 go@1e20af02 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.25s)
panic: dial tcp 127.0.0.1:49237: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:49237: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0xc25da40, 0xc000384000})
	/tmp/buildlet/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/tmp/buildlet/go/src/testing/testing.go:1634 +0x377
panic({0xc25da40?, 0xc000384000?})
	/tmp/buildlet/go/src/runtime/panic.go:759 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc00007a820)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:53 +0x28e
testing.tRunner(0xc00007a820, 0xc286f60)
	/tmp/buildlet/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	/tmp/buildlet/go/src/testing/testing.go:1742 +0x390

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-03-25 20:14 x_tools-go1.22-windows-amd64-longtest tools@71acab9a release-branch.go1.22@35b1a146 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.29s)
panic: dial tcp 127.0.0.1:52368: connectex: No connection could be made because the target machine actively refused it. [recovered]
	panic: dial tcp 127.0.0.1:52368: connectex: No connection could be made because the target machine actively refused it.

goroutine 19 [running]:
testing.tRunner.func1.2({0xbe8e60, 0xc000100780})
	C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:1634 +0x377
panic({0xbe8e60?, 0xc000100780?})
	C:/b/s/w/ir/x/w/goroot/src/runtime/panic.go:770 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	C:/b/s/w/ir/x/w/targetrepo2447053508/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc0001604e0)
	C:/b/s/w/ir/x/w/targetrepo2447053508/internal/jsonrpc2/serve_test.go:53 +0x28e
testing.tRunner(0xc0001604e0, 0xc21fd8)
	C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x390

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-04-15 15:07 dragonfly-amd64-622 tools@5e04895f go@7b10c49e x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.19s)
panic: dial tcp 127.0.0.1:55408: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:55408: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x5bd080, 0xc0000168c0})
	/tmp/workdir/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1634 +0x377
panic({0x5bd080?, 0xc0000168c0?})
	/tmp/workdir/go/src/runtime/panic.go:759 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc00009a9c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:54 +0x2aa
testing.tRunner(0xc00009a9c0, 0x5f5c00)
	/tmp/workdir/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	/tmp/workdir/go/src/testing/testing.go:1742 +0x390

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-04-19 12:38 linux-s390x-ibm tools@618670db go@f0d6ddfa x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
--- FAIL: TestIdleTimeout (0.46s)
panic: dial tcp 127.0.0.1:38873: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:38873: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x22c040, 0xc000388050})
	/data/golang/workdir/go/src/testing/testing.go:1631 +0x2dc
testing.tRunner.func1()
	/data/golang/workdir/go/src/testing/testing.go:1634 +0x3ee
panic({0x22c040, 0xc000388050})
	/data/golang/workdir/go/src/runtime/panic.go:759 +0x11a
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:34 +0xe2
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc0000949c0)
	/data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve_test.go:53 +0x2f6
testing.tRunner(0xc0000949c0, 0x265478)
	/data/golang/workdir/go/src/testing/testing.go:1689 +0x14a
created by testing.(*T).Run in goroutine 1
	/data/golang/workdir/go/src/testing/testing.go:1742 +0x47c

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-05-31 21:21 x_tools-go1.22-openbsd-amd64 tools@b6235391 release-branch.go1.22@74565750 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.30s)
panic: dial tcp 127.0.0.1:44136: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:44136: connect: connection refused

goroutine 18 [running]:
testing.tRunner.func1.2({0x5b2580, 0xc00011c780})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1634 +0x377
panic({0x5b2580?, 0xc00011c780?})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:770 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/home/swarming/.swarming/w/ir/x/w/targetrepo2014859652/internal/jsonrpc2/serve_test.go:34 +0x65
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc000178340)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2014859652/internal/jsonrpc2/serve_test.go:53 +0x28e
testing.tRunner(0xc000178340, 0x5eb048)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x390

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-06-13 17:33 x_tools-go1.21-darwin-arm64_12 tools@a69d9a2c release-branch.go1.21@74ac37e9 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
    serve_test.go:63: run() returned error <nil>, want timed out waiting for new connections
--- FAIL: TestIdleTimeout (60.02s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-08-06 19:12 x_tools-go1.22-darwin-amd64-race tools@3057be8f release-branch.go1.22@cb4eee69 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.14s)
panic: dial tcp 127.0.0.1:49637: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:49637: connect: connection refused

goroutine 34 [running]:
testing.tRunner.func1.2({0xbece780, 0xc0000900a0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1631 +0x3f7
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1634 +0x6b6
panic({0xbece780?, 0xc0000900a0?})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:770 +0x132
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3756594197/internal/jsonrpc2/serve_test.go:34 +0x99
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0xc0001e2340)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3756594197/internal/jsonrpc2/serve_test.go:53 +0x4df
testing.tRunner(0xc0001e2340, 0xbef9820)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0x21f
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x826

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-09-11 21:24 x_tools-gotip-linux-arm64-longtest tools@51571182 go@547baafa x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.23s)
panic: dial tcp 127.0.0.1:41757: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:41757: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x1dece0, 0x400013a190})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1706 +0x1a4
testing.tRunner.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1709 +0x334
panic({0x1dece0?, 0x400013a190?})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:787 +0x124
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/home/swarming/.swarming/w/ir/x/w/targetrepo2819223717/internal/jsonrpc2/serve_test.go:34 +0x74
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x4000003c00)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2819223717/internal/jsonrpc2/serve_test.go:53 +0x208
testing.tRunner(0x4000003c00, 0x21a9e0)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1764 +0xe4
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1823 +0x368

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-12-11 14:12 x_tools-gotip-netbsd-arm64 tools@82b6f75c go@6c25cf1c x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.12s)
panic: dial tcp 127.0.0.1:55914: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:55914: connect: connection refused

goroutine 7 [running]:
testing.tRunner.func1.2({0x1e6e40, 0x40004a0000})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1706 +0x1ac
testing.tRunner.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1709 +0x334
panic({0x1e6e40?, 0x40004a0000?})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:787 +0x124
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/home/swarming/.swarming/w/ir/x/w/targetrepo185449978/internal/jsonrpc2/serve_test.go:34 +0x74
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x400017a1c0)
	/home/swarming/.swarming/w/ir/x/w/targetrepo185449978/internal/jsonrpc2/serve_test.go:54 +0x21c
testing.tRunner(0x400017a1c0, 0x223590)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1764 +0xe4
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1823 +0x374

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2024-12-11 19:26 x_tools-go1.22-netbsd-arm64 tools@d405635a release-branch.go1.22@8f3f22ee x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.43s)
panic: dial tcp 127.0.0.1:51872: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:51872: connect: connection refused

goroutine 19 [running]:
testing.tRunner.func1.2({0x1bbac0, 0x40000ce960})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1631 +0x1c4
testing.tRunner.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1634 +0x33c
panic({0x1bbac0?, 0x40000ce960?})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:770 +0x124
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/home/swarming/.swarming/w/ir/x/w/targetrepo1439400540/internal/jsonrpc2/serve_test.go:34 +0x7c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x40000d0680)
	/home/swarming/.swarming/w/ir/x/w/targetrepo1439400540/internal/jsonrpc2/serve_test.go:53 +0x21c
testing.tRunner(0x40000d0680, 0x1f37c8)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0xec
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x318

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2025-01-02 17:04 x_tools-go1.22-netbsd-arm64 tools@71b5dfef release-branch.go1.22@8f3f22ee x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.65s)
panic: dial tcp 127.0.0.1:54778: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:54778: connect: connection refused

goroutine 6 [running]:
testing.tRunner.func1.2({0x1bbac0, 0x400007c910})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1631 +0x1c4
testing.tRunner.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1634 +0x33c
panic({0x1bbac0?, 0x400007c910?})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:770 +0x124
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/home/swarming/.swarming/w/ir/x/w/targetrepo2598629821/internal/jsonrpc2/serve_test.go:34 +0x7c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x4000128680)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2598629821/internal/jsonrpc2/serve_test.go:53 +0x21c
testing.tRunner(0x4000128680, 0x1f37c8)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0xec
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x318

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2" && test == "TestIdleTimeout"
2025-01-09 21:25 x_tools-go1.23-netbsd-arm64 tools@1b796a93 release-branch.go1.23@1dde0b48 x/tools/internal/jsonrpc2.TestIdleTimeout (log) 
=== RUN   TestIdleTimeout
--- FAIL: TestIdleTimeout (0.19s)
panic: dial tcp 127.0.0.1:51363: connect: connection refused [recovered]
	panic: dial tcp 127.0.0.1:51363: connect: connection refused

goroutine 7 [running]:
testing.tRunner.func1.2({0x1df1c0, 0x40000ac780})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1632 +0x1bc
testing.tRunner.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1635 +0x334
panic({0x1df1c0?, 0x40000ac780?})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:785 +0x124
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout.func1()
	/home/swarming/.swarming/w/ir/x/w/targetrepo2779196740/internal/jsonrpc2/serve_test.go:34 +0x7c
golang.org/x/tools/internal/jsonrpc2.TestIdleTimeout(0x40000ae680)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2779196740/internal/jsonrpc2/serve_test.go:53 +0x20c
testing.tRunner(0x40000ae680, 0x21a968)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690 +0xe4
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x314

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Active
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@ianthehat @bcmills @adonovan @gopherbot