Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestFifoEOF failures #55207

Closed
gopherbot opened this issue Sep 20, 2022 · 5 comments
Closed

os: TestFifoEOF failures #55207

gopherbot opened this issue Sep 20, 2022 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Sep 20, 2022 •
edited by bcmills 

#!watchflakes
post <- pkg == "os" && test == "TestFifoEOF" && date < "2023-01-01"

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022 •
edited

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "os" && test == "TestFifoEOF"
2022-08-19 01:34 freebsd-arm64-dmgk go@ee833ed7 os.TestFifoEOF (log) 
--- FAIL: TestFifoEOF (1.88s)
    fifo_test.go:99: timed out waiting for read
    fifo_test.go:88: read /tmp/workdir-host-freebsd-arm64-dmgk/tmp/TestFifoEOF2021794912/001/fifo: file already closed
    fifo_test.go:77: error closing reader: close /tmp/workdir-host-freebsd-arm64-dmgk/tmp/TestFifoEOF2021794912/001/fifo: file already closed
    fifo_test.go:57: error writing to fifo: write /tmp/workdir-host-freebsd-arm64-dmgk/tmp/TestFifoEOF2021794912/001/fifo: broken pipe

— watchflakes

@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@gopherbot gopherbot changed the title os: flaky TestFifoEOF os: TestFifoEOF failures Sep 20, 2022
@gopherbot gopherbot reopened this Dec 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "os" && test == "TestFifoEOF"
2022-12-12 23:10 freebsd-arm64-dmgk go@b16e94d1 os.TestFifoEOF (log) 
--- FAIL: TestFifoEOF (1.09s)
    fifo_test.go:91: line 0
    fifo_test.go:91: line 1
    fifo_test.go:91: line 2
    fifo_test.go:99: timed out waiting for read

— watchflakes

@bcmills
Copy link
Member

bcmills commented Sep 19, 2023

This issue conflates two different failure modes. Added a date constraint to get watchflakes to file a fresh issue for the new failure mode.

@golang golang deleted a comment from gopherbot Sep 19, 2023
@golang golang deleted a comment from gopherbot Sep 19, 2023
@bcmills
Copy link
Member

bcmills commented Sep 19, 2023

(Also deleted spurious matches, just in case watchflakes sees them as already-reported.)

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
@bcmills bcmills mentioned this issue Sep 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rsc @bcmills @gopherbot