Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln/cmd/govulncheck: TestCommand failures #55210

Closed
gopherbot opened this issue Sep 20, 2022 · 2 comments
Closed

x/vuln/cmd/govulncheck: TestCommand failures #55210

gopherbot opened this issue Sep 20, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. x/vuln
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
post <- pkg == "golang.org/x/vuln/cmd/govulncheck" && test == "TestCommand"

Bug automatically created to track these flakes.

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Contributor Author

gopherbot commented Sep 20, 2022

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/cmd/govulncheck" && test == "TestCommand"
2022-08-24 14:46 linux-amd64-wsl vuln@bf90c096 go@55d96f98 golang.org/x/vuln/cmd/govulncheck.TestCommand (log)
--- FAIL: TestCommand (46.19s)
    cmdtest.go:444: $ govulncheck /tmp/workdir-host-linux-amd64-wsl/tmp/buildtest437382011/novuln
    cmdtest.go:475: govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

        Scanning for dependencies with known vulnerabilities...
        No vulnerabilities found.

    cmdtest.go:444: $ govulncheck /tmp/workdir-host-linux-amd64-wsl/tmp/buildtest1756097020/vuln
    cmdtest.go:475: govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

...
    --- FAIL: TestCommand/testdata/default (2.85s)
        cmdtest.go:320: testdata/default.ct:11: want=-, got=+
            $ cdmodule vuln
            $ govulncheck . --> FAIL 3
              []string{
              	... // 22 identical elements
              	"action. See https://go.dev/security/vulncheck for details.",
              	"",
            - 	"Vulnerability #1: GO-2021-0265",
            + 	"Vulnerability #1: GO-2022-0592",
...
              		".",
              	}, ""),
              	"  Found in: github.com/tidwall/gjson@v1.9.2",
              	"  Fixed in: github.com/tidwall/gjson@v1.9.3",
              	strings.Join({
              		"  More info: https://pkg.go.dev/vuln/GO-202",
            - 		"2-0592",
            + 		"1-0265",
              	}, ""),
              }

watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc
Copy link
Contributor

rsc commented Sep 20, 2022

Stopped.

@rsc rsc closed this as completed Sep 20, 2022
@rsc rsc moved this to Done in Test Flakes Sep 20, 2022
@gopherbot gopherbot changed the title x/vuln/cmd/govulncheck: flaky TestCommand x/vuln/cmd/govulncheck: TestCommand failures Sep 20, 2022
@rsc rsc removed this from Test Flakes Sep 21, 2022
@golang golang locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. x/vuln
Projects
None yet
Development

No branches or pull requests

2 participants