Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: TestLabelSystemstack failures #55228

Closed
gopherbot opened this issue Sep 20, 2022 · 4 comments
Closed

runtime/pprof: TestLabelSystemstack failures #55228

gopherbot opened this issue Sep 20, 2022 · 4 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "runtime/pprof" && test == "TestLabelSystemstack"

Bug automatically created to track these flakes.

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 20, 2022

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "runtime/pprof" && test == "TestLabelSystemstack"
2022-09-06 15:49 linux-amd64-longtest go@e3885c4e runtime/pprof.TestLabelSystemstack (log)
--- FAIL: TestLabelSystemstack (5.14s)
    pprof_test.go:539: total 5783 CPU profile samples collected:
        17: 0x420403 (runtime.(*gcControllerState).commit:1283) 0x420a53 (runtime.gcControllerCommit:1542) 0x4204a4 (runtime.setGCPercent.func1:1310) 0x4665a8 (runtime.systemstack:492) 0x463015 (runtime/debug.setGCPercent:1307) 0x54e031 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x54e21b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1: 0x468386 (runtime.procyield:756) 0x40b232 (runtime.lock2:88) 0x43e693 (runtime.lockWithRank:22 runtime.lock:48 runtime.goschedImpl:3424) 0x43e870 (runtime.gosched_m:3436) 0x466522 (runtime.mcall:448) labels: map[]

        7: 0x40b267 (runtime.lock2:98) 0x420455 (runtime.lockWithRank:22 runtime.lock:48 runtime.setGCPercent.func1:1308) 0x4665a8 (runtime.systemstack:492) 0x463015 (runtime/debug.setGCPercent:1307) 0x54e031 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x54e21b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1082: 0x46a523 (runtime.futex:560) 0x431295 (runtime.futexsleep:69) 0x40b1f8 (runtime.lock2:107) 0x420455 (runtime.lockWithRank:22 runtime.lock:48 runtime.setGCPercent.func1:1308) 0x4665a8 (runtime.systemstack:492) 0x463015 (runtime/debug.setGCPercent:1307) 0x54e031 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x54e21b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

...
        1: 0x420bf3 (runtime.gcPaceScavenger:182) 0x420aa6 (runtime.gcControllerCommit:1557) 0x4204a4 (runtime.setGCPercent.func1:1310) 0x4665a8 (runtime.systemstack:492) 0x463015 (runtime/debug.setGCPercent:1307) 0x54e031 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x54e21b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1: 0x40b2dd (runtime.lock2:85) 0x420455 (runtime.lockWithRank:22 runtime.lock:48 runtime.setGCPercent.func1:1308) 0x4665a8 (runtime.systemstack:492) 0x463015 (runtime/debug.setGCPercent:1307) 0x54e031 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x54e21b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1: 0x42003d (runtime/internal/atomic.(*Uint64).Load:313 runtime.(*gcControllerState).heapGoalInternal:963) 0x420184 (runtime.(*gcControllerState).trigger:1138) 0x420a84 (runtime.gcControllerCommit:1555) 0x4204a4 (runtime.setGCPercent.func1:1310) 0x4665a8 (runtime.systemstack:492) 0x463015 (runtime/debug.setGCPercent:1307) 0x54e031 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x54e21b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1: labels: map[key:[value]]

    pprof_test.go:610: runtime.systemstack;key=value: 5739
    pprof_test.go:1885: Sample labeled got true want false: 

watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 20, 2022
@gopherbot gopherbot changed the title runtime/pprof: flaky TestLabelSystemstack runtime/pprof: TestLabelSystemstack failures Sep 20, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime/pprof" && test == "TestLabelSystemstack"
2022-09-26 20:52 linux-amd64-nounified go@84f95aa8 runtime/pprof.TestLabelSystemstack (log)
--- FAIL: TestLabelSystemstack (0.31s)
    pprof_test.go:539: total 110 CPU profile samples collected:
        23: 0x46a923 (runtime.futex:560) 0x431e75 (runtime.futexwakeup:82) 0x40b572 (runtime.unlock2:121) 0x420b12 (runtime.unlockWithRank:32 runtime.unlock:112 runtime.setGCPercent.func1:1311) 0x4669a8 (runtime.systemstack:492) 0x463325 (runtime/debug.setGCPercent:1307) 0x5515b1 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x55179b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        16: 0x46aa87 (runtime.osyield:658) 0x40b446 (runtime.lock2:98) 0x420ab5 (runtime.lockWithRank:22 runtime.lock:48 runtime.setGCPercent.func1:1308) 0x4669a8 (runtime.systemstack:492) 0x463325 (runtime/debug.setGCPercent:1307) 0x5515b1 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x55179b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        23: 0x46a923 (runtime.futex:560) 0x431d95 (runtime.futexsleep:69) 0x40b3d8 (runtime.lock2:107) 0x420ab5 (runtime.lockWithRank:22 runtime.lock:48 runtime.setGCPercent.func1:1308) 0x4669a8 (runtime.systemstack:492) 0x463325 (runtime/debug.setGCPercent:1307) 0x5515b1 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x55179b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        32: 0x468786 (runtime.procyield:756) 0x40b412 (runtime.lock2:88) 0x420ab5 (runtime.lockWithRank:22 runtime.lock:48 runtime.setGCPercent.func1:1308) 0x4669a8 (runtime.systemstack:492) 0x463325 (runtime/debug.setGCPercent:1307) 0x5515b1 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x55179b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

...
        1: 0x468784 (runtime.procyield:755) 0x40b412 (runtime.lock2:88) 0x420ab5 (runtime.lockWithRank:22 runtime.lock:48 runtime.setGCPercent.func1:1308) 0x4669a8 (runtime.systemstack:492) 0x463325 (runtime/debug.setGCPercent:1307) 0x5515b1 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x55179b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1: 0x4212a8 (runtime.gcPaceScavenger:208) 0x421106 (runtime.gcControllerCommit:1557) 0x420b04 (runtime.setGCPercent.func1:1310) 0x4669a8 (runtime.systemstack:492) 0x463325 (runtime/debug.setGCPercent:1307) 0x5515b1 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x55179b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1: 0x421102 (runtime.gcControllerCommit:1557) 0x420b04 (runtime.setGCPercent.func1:1310) 0x4669a8 (runtime.systemstack:492) 0x463325 (runtime/debug.setGCPercent:1307) 0x5515b1 (runtime/debug.SetGCPercent:96 runtime/pprof.labelHog:1902) 0x55179b (runtime/pprof.parallelLabelHog.func1:1915) labels: map[key:[value]]

        1: labels: map[key:[value]]

    pprof_test.go:610: runtime.systemstack;key=value: 109
    pprof_test.go:1885: Sample labeled got true want false: 

watchflakes

@mknyszek
Copy link
Contributor

This may be a duplicate of #51550.

@mknyszek mknyszek added this to the Go1.20 milestone Sep 28, 2022
@cherrymui
Copy link
Member

Close as a dup.

@cherrymui cherrymui closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Done
Development

No branches or pull requests

4 participants