Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
net: external network tests flaky #5523
This is the first of a few bugs to track test flakiness and get it fixed. Even on a reasonably reliable 10 Mbps DSL internet connection, tests that touch the external network fail from time to time. Example: --- FAIL: TestDialGoogleIPv4 (10.03 seconds) dialgoogle_test.go:66: lookup www.google.com: lookup www.google.com: no such host This leads to a constant stream of failures that have to be triaged (a few per day). These tests need to be skipped based on an environment variable (or something) so that no matter if they're run through "go test", run.bash, etc., they can easily be skipped. Everyone else running go test net and make.bash are constantly testing these.
i prefer a GO_NO_EXTERNAL_NETWORK or similar named environment variables to control these tests. another case is in go.crypto/ssh/test where it tries to connect encrypted.google.com and causing builder failures (http://build.golang.org/log/b8a386d137101f8da0a77c5688f7e6ece8400257)