Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: external network tests flaky #5523

Closed
alberts opened this issue May 21, 2013 · 16 comments
Closed

net: external network tests flaky #5523

alberts opened this issue May 21, 2013 · 16 comments

Comments

@alberts
Copy link
Contributor

@alberts alberts commented May 21, 2013

This is the first of a few bugs to track test flakiness and get it fixed.

Even on a reasonably reliable 10 Mbps DSL internet connection, tests that touch the
external network fail from time to time.

Example:

--- FAIL: TestDialGoogleIPv4 (10.03 seconds)
dialgoogle_test.go:66: lookup www.google.com: lookup www.google.com: no such host

This leads to a constant stream of failures that have to be triaged (a few per day).

These tests need to be skipped based on an environment variable (or something) so that
no matter if they're run through "go test", run.bash, etc., they can easily be
skipped.

Everyone else running go test net and make.bash are constantly testing these.
@minux

This comment has been minimized.

Copy link
Member

@minux minux commented May 21, 2013

Comment 1:

i prefer a GO_NO_EXTERNAL_NETWORK or similar named environment variables to control
these tests.
another case is in go.crypto/ssh/test where it tries to connect encrypted.google.com and
causing builder failures
(http://build.golang.org/log/b8a386d137101f8da0a77c5688f7e6ece8400257)
@alberts

This comment has been minimized.

Copy link
Contributor Author

@alberts alberts commented May 21, 2013

Comment 2:

Sounds good to me. If there's consensus, I'll prepare a CL.
@mikioh

This comment has been minimized.

Copy link
Contributor

@mikioh mikioh commented May 22, 2013

Comment 3:

Doesn't testExternal work well? I think tests with flags -short=true or -external=false
does work well on any environment. How did you run?
@alberts

This comment has been minimized.

Copy link
Contributor Author

@alberts alberts commented May 22, 2013

Comment 4:

How do I turn testExternal off when running with run.bash?
Using testExternal is also tricky when you just want to do go test std.
I'm trying to run all the Go tests in the same way that everyone runs them, but also in
extra ways that expose more subtle race conditions/bugs.
@mikioh

This comment has been minimized.

Copy link
Contributor

@mikioh mikioh commented May 22, 2013

Comment 5:

Ah, I see. That's the reason why prefix is "testing".
@alberts

This comment has been minimized.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 7:

Labels changed: added priority-later, go1.2, removed priority-triage.

Status changed to Accepted.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Sep 10, 2013

Comment 8:

Labels changed: added testing.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Sep 11, 2013

Comment 9:

Labels changed: added go1.2maybe, removed go1.2.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Oct 2, 2013

Comment 10:

Labels changed: added go1.3, removed go1.2maybe.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 11:

Labels changed: added release-go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 12:

Labels changed: removed go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 13:

Labels changed: added repo-main.

@mikioh

This comment has been minimized.

Copy link
Contributor

@mikioh mikioh commented Jan 22, 2014

Comment 14:

Labels changed: added release-go1.4, removed release-go1.3.

@hanwen

This comment has been minimized.

Copy link
Contributor

@hanwen hanwen commented Apr 12, 2014

Comment 15:

Fixed. The external network test has been removed from go.crypto/ssh now.
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Sep 16, 2014

Comment 16:

Labels changed: added release-none, removed release-go1.4.

@alberts alberts closed this Dec 31, 2014
@golang golang locked and limited conversation to collaborators Jun 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.