You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added experimentalWatchedFileDelay for LSP clients that don't buffer file change notifications. In retrospect, I think this was a mistake:
Clients have more knowledge of user intent, and so are better fit to implement change buffering (e.g. during branch switches)
Clients should control the ordering of changes. By buffering change notifications gopls observes a different ordering of changes than is sent by the client. This shouldn't matter in practice, but feels incorrect.
Change processing should be fast. In some sense, this setting was only working around a limitation of gopls that it had to do a remarkable amount of bookkeeping for each change. We've since improved that significantly (https://go.dev/issue/45686).
Therefore, I think we should remove this setting (which never made it out of 'experimental' anyway), to reduce complexity within gopls.
Activity
gopherbot commentedon Sep 26, 2022
Change https://go.dev/cl/434640 mentions this issue:
gopls: deprecate three experimental featuresgopls: update to 0.11.0
gopls: update to 0.11.0
Bump golang.org/x/tools from 0.9.3 to 0.10.0 (#360)
⬆️ Bump golang.org/x/tools from 0.9.3 to 0.10.0 in /src (#3633)
chore(deps): Bump golang.org/x/tools from 0.9.3 to 0.10.0 in /package…
chore(deps): Bump golang.org/x/tools from 0.9.3 to 0.10.0 in /package…
build(deps): bump golang.org/x/tools from 0.9.3 to 0.10.0 (#122)
Merge #29
chore(deps): bump golang.org/x/tools from 0.9.3 to 0.10.0 in /tools (#…
build(deps): Bump golang.org/x/tools from 0.9.3 to 0.10.0 (#455)
gopls: deprecate three experimental features