Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript failures #55311

Open
gopherbot opened this issue Sep 21, 2022 · 9 comments
Open

cmd/go: TestScript failures #55311

gopherbot opened this issue Sep 21, 2022 · 9 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Sep 21, 2022

#!watchflakes
post <- pkg == "cmd/go" && test == "TestScript"

Issue created automatically to collect these failures.

Example (log):

go test proxy running at GOPROXY=http://127.0.0.1:36901/mod
==================
WARNING: DATA RACE
Read at 0x000001427d60 by goroutine 275:
  cmd/go/internal/base.AtExit()
      /tmp/workdir/go/src/cmd/go/internal/base/base.go:110 +0x5d0
  cmd/go/internal/work.(*Builder).Init()
      /tmp/workdir/go/src/cmd/go/internal/work/action.go:273 +0x54c
  cmd/go_test.(*testScript).cmdCc()
      /tmp/workdir/go/src/cmd/go/script_test.go:560 +0x12f
...
--- FAIL: TestScript (0.04s)
    --- FAIL: TestScript/doc (2.67s)
        script_test.go:270: 
            # (2022-08-08T17:13:12Z)
            # go doc --help (0.149s)
            # go help doc (0.087s)
            # go doc <pkg> (0.309s)
            # go doc <pkg> <sym> (0.315s)
            # go doc <pkg> <sym> <method> (0.159s)
            # go doc <pkg>.<sym> (0.171s)
...
            # (2022-08-08T17:13:13Z)
            # Issue 35837: "go vet -<analyzer> <std package>" should use the requested
            # analyzers, not the default analyzers for 'go test'. (1.859s)
            # Issue 37030: "go vet <std package>" without other flags should disable the
            # unsafeptr check by default. (1.915s)
            # However, it should be enabled if requested explicitly. (1.683s)
            # -unreachable is disabled during test but on during plain vet. (1.801s)
            # A flag terminator should be allowed before the package list. (0.652s)

        testing.go:1319: race detected during execution of test

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 21, 2022
@gopherbot
Copy link
Author

gopherbot commented Sep 21, 2022

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestScript"
2022-08-08 16:57 freebsd-amd64-race go@c3833a55 cmd/go.TestScript (log)
go test proxy running at GOPROXY=http://127.0.0.1:36901/mod
==================
WARNING: DATA RACE
Read at 0x000001427d60 by goroutine 275:
  cmd/go/internal/base.AtExit()
      /tmp/workdir/go/src/cmd/go/internal/base/base.go:110 +0x5d0
  cmd/go/internal/work.(*Builder).Init()
      /tmp/workdir/go/src/cmd/go/internal/work/action.go:273 +0x54c
  cmd/go_test.(*testScript).cmdCc()
      /tmp/workdir/go/src/cmd/go/script_test.go:560 +0x12f
...
--- FAIL: TestScript (0.04s)
    --- FAIL: TestScript/doc (2.67s)
        script_test.go:270: 
            # (2022-08-08T17:13:12Z)
            # go doc --help (0.149s)
            # go help doc (0.087s)
            # go doc <pkg> (0.309s)
            # go doc <pkg> <sym> (0.315s)
            # go doc <pkg> <sym> <method> (0.159s)
            # go doc <pkg>.<sym> (0.171s)
...
            # (2022-08-08T17:13:13Z)
            # Issue 35837: "go vet -<analyzer> <std package>" should use the requested
            # analyzers, not the default analyzers for 'go test'. (1.859s)
            # Issue 37030: "go vet <std package>" without other flags should disable the
            # unsafeptr check by default. (1.915s)
            # However, it should be enabled if requested explicitly. (1.683s)
            # -unreachable is disabled during test but on during plain vet. (1.801s)
            # A flag terminator should be allowed before the package list. (0.652s)

        testing.go:1319: race detected during execution of test
2022-08-09 18:32 linux-amd64-longtest go@beebd537 cmd/go.TestScript (log)
go test proxy running at GOPROXY=http://127.0.0.1:33027/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/mod_replace_gopkgin (12.55s)
        script_test.go:270: 
            # (2022-08-09T18:56:44Z)
            # Regression test for golang.org/issue/34254:
            # a clone of gopkg.in/[…].vN should be replaceable by
            # a fork hosted at corp.example.com/[…]/vN,
            # even if there is an explicit go.mod file containing the
            # gopkg.in path. (0.000s)
...
            	18:56:48.755444 http.c:715              => Send header: content-length: 128
            	18:56:48.755447 http.c:715              => Send header:
            	18:56:48.755497 http.c:756              == Info: We are completely uploaded and fine
            	18:56:48.755704 http.c:756              == Info: HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)
            	18:56:48.755717 http.c:756              == Info: stopped the pause stream!
            	18:56:48.755726 http.c:756              == Info: Connection #0 to host go.googlesource.com left intact
            	error: RPC failed; curl 92 HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)
            	fatal: expected flush after ref listing
            [exit status 1]
            FAIL: testdata/script/mod_replace_gopkgin.txt:20: unexpected command failure
2022-08-22 18:57 linux-386-longtest go@a74e5f58 cmd/go.TestScript (log)
go test proxy running at GOPROXY=http://127.0.0.1:37473/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/get_insecure_env (2.19s)
        script_test.go:282: 
            # (2022-08-22T19:30:35Z)
            # GOPATH: Set up (0.000s)
            # GOPATH: Try go get -d of HTTP-only repo (should fail). (0.084s)
            # GOPATH: Try again with invalid GOINSECURE (should fail). (0.052s)
            # GOPATH: Try with correct GOINSECURE (should succeed). (2.050s)
            > env GOINSECURE=insecure.go-get-issue-15410.appspot.com/pkg/p
            > go get -d insecure.go-get-issue-15410.appspot.com/pkg/p
            [stderr]
            package insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg?go-get=1: 503 Service Unavailable
            [exit status 1]
            FAIL: testdata/script/get_insecure_env.txt:16: unexpected command failure
2022-09-06 15:47 linux-amd64-longtest go@91a1b554 cmd/go.TestScript (log)
go test proxy running at GOPROXY=http://127.0.0.1:42819/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/mod_init_glide (0.56s)
        script_test.go:282: 
            # (2022-09-06T16:13:29Z)
            # Regression test for golang.org/issue/32161:
            # 'go mod init' did not locate tags when resolving a commit to a pseudo-version. (0.560s)
            > go mod init x
            [stderr]
            go: creating new go.mod: module x
...
            	go mod tidy
            > cmpenv go.mod go.mod.out
            [diff -go.mod +go.mod.out]
             module x

             go 1.20
            +
            +require github.com/rsc/legacytest v1.1.0-pre.0.20180717164849-fb3c628075e3

            FAIL: testdata/script/mod_init_glide.txt:11: go.mod and go.mod.out differ

watchflakes

@bcmills
Copy link
Member

bcmills commented Sep 21, 2022

2022-08-08 16:57 freebsd-amd64-race go@c3833a55 cmd/go.TestScript (log)

That one is #54423, fixed at head and backported to 1.18 and 1.19. Not sure how to suppress watchflakes for it, or whether that's even necessary.

@bcmills
Copy link
Member

bcmills commented Sep 21, 2022

2022-08-09 18:32 linux-amd64-longtest go@beebd537 cmd/go.TestScript (log)

Looks like a server-side flake from go.googlesource.com, which would be a new failure mode for #50541.

@bcmills
Copy link
Member

bcmills commented Sep 21, 2022

2022-08-22 18:57 linux-386-longtest go@a74e5f58 cmd/go.TestScript (log)

That's #54608. I've attempted to add a watchflakes expression for it, but I'm not sure whether it will work. 🤔

@bcmills
Copy link
Member

bcmills commented Sep 21, 2022

2022-09-06 15:47 linux-amd64-longtest go@91a1b554 cmd/go.TestScript (log)

That's #52820.

@gopherbot
Copy link
Author

gopherbot commented Sep 23, 2022

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestScript"
2022-09-23 15:14 darwin-amd64-11_0 go@68fa3696 cmd/go.TestScript (log)
go test proxy running at GOPROXY=http://127.0.0.1:54034/mod
--- FAIL: TestScript (0.03s)
    --- FAIL: TestScript/mod_require_exclude (1.19s)
        script_test.go:282: 
            # (2022-09-23T15:30:03Z)
            # build with no newer version to satisfy exclude (0.010s)
            # With the selected version excluded, commands that query that version without
            # updating go.mod should fail. (0.097s)
            # The failure message should be clear when -mod=vendor is implicit. (0.139s)
            # With the selected version excluded, commands that load only modules should
            # drop the excluded module. (0.035s)
            # With the latest version excluded, 'go list' should resolve needed packages
            # from the next-highest version. (0.457s)
            # build with newer version available (0.343s)
            # build with excluded newer version (0.045s)
            > cp go.mod3 go.mod
            > go list -mod=mod -f '{{with .Module}}{{.Path}} {{.Version}}{{end}}' all
            [stderr]
            go: errors parsing go.mod:
            $WORK/gopath/src/go.mod:1: unexpected input character '\x00'
            [exit status 1]
            FAIL: testdata/script/mod_require_exclude.txt:58: unexpected command failure

watchflakes

@bcmills
Copy link
Member

bcmills commented Sep 23, 2022

#52493

@gopherbot
Copy link
Author

gopherbot commented Sep 28, 2022

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestScript"
2022-09-27 21:00 linux-amd64-longtest go@871a3a40 cmd/go.TestScript (log)
go test proxy running at GOPROXY=http://127.0.0.1:46033/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/mod_replace_gopkgin (33.32s)
        script_test.go:282: 
            # (2022-09-27T21:29:37Z)
            # Regression test for golang.org/issue/34254:
            # a clone of gopkg.in/[…].vN should be replaceable by
            # a fork hosted at corp.example.com/[…]/vN,
            # even if there is an explicit go.mod file containing the
            # gopkg.in path. (0.000s)
...
            	21:29:44.841637 http.c:715              <= Recv header: date: Tue, 27 Sep 2022 21:29:44 GMT
            	21:29:44.841641 http.c:703              <= Recv header, 0000000002 bytes (0x00000002)
            	21:29:44.841645 http.c:715              <= Recv header:
            	21:30:06.089255 http.c:756              == Info: Connection #0 to host go.googlesource.com left intact
            	error: 10224 bytes of body are still expected
            	fetch-pack: unexpected disconnect while reading sideband packet
            	fatal: early EOF
            	fatal: index-pack failed
            [exit status 1]
            FAIL: testdata/script/mod_replace_gopkgin.txt:20: unexpected command failure

watchflakes

@bcmills
Copy link
Member

bcmills commented Sep 28, 2022

#52490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

2 participants