Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: log/syslog tests take too long when run with the race detector #5547

Closed
alberts opened this issue May 23, 2013 · 7 comments

Comments

Projects
None yet
4 participants
@alberts
Copy link
Contributor

commented May 23, 2013

Since about this change:

https://code.google.com/p/go/source/detail?r=8d5f80a6d6db

the log/syslog tests are timing out when run under the race detector:

go test -race log/syslog -v

=== RUN TestConcurrentReconnect-125
*** Test killed: ran too long (10m0s).
FAIL    log/syslog  600.009s
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 23, 2013

Comment 1:

I'm not seeing this on my Ubuntu precise amd64 system.
> go test -race log/syslog -v
=== RUN TestWithSimulated
--- PASS: TestWithSimulated (0.81 seconds)
=== RUN TestFlap
--- PASS: TestFlap (0.00 seconds)
=== RUN TestNew
--- PASS: TestNew (0.00 seconds)
=== RUN TestNewLogger
--- PASS: TestNewLogger (0.00 seconds)
=== RUN TestDial
--- PASS: TestDial (0.00 seconds)
=== RUN TestWrite
--- PASS: TestWrite (1.21 seconds)
=== RUN TestConcurrentWrite
--- PASS: TestConcurrentWrite (0.00 seconds)
=== RUN TestConcurrentReconnect
--- PASS: TestConcurrentReconnect (0.03 seconds)
PASS
ok      log/syslog  3.071s
@alberts

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2013

Comment 2:

Try a value of GOMAXPROCS>1?
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 23, 2013

Comment 3:

Ah, right.  Confirmed:
GOMAXPROCS=8 go test -race log/syslog -v
=== RUN TestWithSimulated-8
--- PASS: TestWithSimulated-8 (0.81 seconds)
=== RUN TestFlap-8
--- PASS: TestFlap-8 (0.00 seconds)
=== RUN TestNew-8
--- PASS: TestNew-8 (0.00 seconds)
=== RUN TestNewLogger-8
--- PASS: TestNewLogger-8 (0.00 seconds)
=== RUN TestDial-8
--- PASS: TestDial-8 (0.00 seconds)
=== RUN TestWrite-8
--- PASS: TestWrite-8 (1.21 seconds)
=== RUN TestConcurrentWrite-8
--- PASS: TestConcurrentWrite-8 (0.00 seconds)
=== RUN TestConcurrentReconnect-8
*** Test killed: ran too long (10m0s).
FAIL    log/syslog  600.004s

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @dvyukov.

Status changed to Accepted.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 23, 2013

Comment 4:

Labels changed: added go1.1.1.

@dvyukov

This comment has been minimized.

Copy link
Member

commented May 24, 2013

Comment 5:

Just a deadlock in test

Status changed to Started.

@dvyukov

This comment has been minimized.

Copy link
Member

commented May 24, 2013

Comment 6:

This issue was closed by revision 0806c97.

Status changed to Fixed.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 30, 2013

Comment 7:

Labels changed: removed go1.1.1.

@alberts alberts added fixed labels May 30, 2013

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.