Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportPersistConnContextLeakMaxConnsPerHost fails in HTTP/2 mode #56021

Open
neild opened this issue Oct 4, 2022 · 0 comments
Open

net/http: TestTransportPersistConnContextLeakMaxConnsPerHost fails in HTTP/2 mode #56021

neild opened this issue Oct 4, 2022 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@neild
Copy link
Contributor

neild commented Oct 4, 2022

TestTransportPersistConnContextLeakMaxConnsPerHost tests that request contexts are eventually garbage collected.

Running this test in HTTP/2 mode (after refactoring to add an HTTP/2 version) results in it failing:

$ go test ./net/http -run=ContextLeakMaxConns
--- FAIL: TestTransportPersistConnContextLeakMaxConnsPerHost (0.22s)
    --- FAIL: TestTransportPersistConnContextLeakMaxConnsPerHost/h2 (0.20s)
        transport_test.go:1963: 63 Contexts still not finalized after 100 GC cycles.

I'm not sure what's going on, but the test looks correct to me. This might be indicative of a real issue. Or maybe I'm missing something.
@neild neild added this to the Backlog milestone Oct 4, 2022
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@neild @cagedmantis