x/sys/windows: add SEC_* constants

[piotr-sneller]

What version of Go are you using (go version)?

1.19.2

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

windows/amd64

What did you expect to see?

Hi,

this is not a "notable change", so I am reporting it as a bug for the lack of a better idea.

CreateFileMapping() can take more protection flags than the windows package defines at the moment. I believe the file would be memory_windows.go; could you please add the following?

SEC_COMMIT           = 0x08000000
SEC_IMAGE            = 0x01000000
SEC_IMAGE_NO_EXECUTE = 0x11000000
SEC_LARGE_PAGES      = 0x80000000
SEC_NOCACHE          = 0x10000000
SEC_RESERVE          = 0x04000000
SEC_WRITECOMBINE     = 0x40000000

[prattmic]

cc @golang/windows

[prattmic]

The Windows folks can say more definitely, but this doesn't sound controversial to me, so I think you can just send a CL adding these.

[alexbrainman]

@piotr-sneller

If you want these flags added to memory_windows.go, you have to do it yourself. Here https://go.dev/doc/contribute is how to contribute. I will be happy to review your change.

But you can just add these consts to your own source files, and use them from there too.

Alex

[piotr-sneller]

@alexbrainman I gladly would, but I got stuck with the legal part, so cannot contribute until it is all resolved. It's approved on my end, but I don't have the time to go through the paperwork ordeal just now. This is the root issue, I believe.

Certainly, I have the missing constants (and more) defined in my own files. But conceptually they don't belong there; it's pure WinAPI and should be provided by the WinAPI wrapper package (for any programming language). Another benefit would be allowing more people to use them straight out of the box.

[alexbrainman]

@alexbrainman I gladly would, but I got stuck with the legal part, so cannot contribute until it is all resolved. It's approved on my end, but I don't have the time to go through the paperwork ordeal just now. This is the root issue, I believe.

No worries. When you are ready.

Certainly, I have the missing constants (and more) defined in my own files. But conceptually they don't belong there; it's pure WinAPI and should be provided by the WinAPI wrapper package (for any programming language). Another benefit would be allowing more people to use them straight out of the box.

Agree.

Alex