Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: diagnostics not cleared after configuration change #56158

Open
findleyr opened this issue Oct 11, 2022 · 0 comments
Open

x/tools/gopls: diagnostics not cleared after configuration change #56158

findleyr opened this issue Oct 11, 2022 · 0 comments
Labels
gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Oct 11, 2022

When gopls receives a major configuration change (one that requires reloading), it does not explicitly purge diagnostics for all files. As a result, if the configuration change causes a file to no longer be considered part of the workspace, or if under the new configuration the file does not have diagnostics, gopls will not re-publish empty diagnostics.

Low priority, as configuration changes are rare, but this is wrong.

@findleyr findleyr added the gopls/metadata Issues related to metadata loading in gopls label Oct 11, 2022
@findleyr findleyr added this to the gopls/later milestone Oct 11, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants