Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestNeedmDeadlock failures #56420

Open
gopherbot opened this issue Oct 25, 2022 · 19 comments
Open

runtime: TestNeedmDeadlock failures #56420

gopherbot opened this issue Oct 25, 2022 · 19 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestNeedmDeadlock (5.11s)
    testenv.go:459: [/data/golang/workdir/tmp/go-build4218498514/testprogcgo.exe NeedmDeadlock] exit status: exit status 1
    crash_cgo_test.go:714: want OK
        , got Hung for 5 seconds

watchflakes

@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Oct 25, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2022-10-20 22:16 linux-s390x-ibm go@4725c71b runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (5.11s)
    testenv.go:459: [/data/golang/workdir/tmp/go-build4218498514/testprogcgo.exe NeedmDeadlock] exit status: exit status 1
    crash_cgo_test.go:714: want OK
        , got Hung for 5 seconds

watchflakes

@mknyszek
Copy link
Contributor

In triage I think we want to see more failures. For context, needm is used on the C -> Go call path to get an m for the C thread. Seems like it might be similar to #43625?

If it happens again on s390x I'll loop in the s390x folks.

@mknyszek mknyszek added this to the Go1.20 milestone Oct 26, 2022
@mknyszek
Copy link
Contributor

This continues to be the only failure in recent memory. At the end of the cycle we should put this into the backlog if we don't see any more issues.

@cherrymui
Copy link
Member

Seems no new failure for quite a while. Move to backlog.

@cherrymui cherrymui modified the milestones: Go1.20, Backlog Jan 10, 2023
@cherrymui cherrymui added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 10, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-01-09 20:25 openbsd-amd64-71 go@0bbd67e5 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (1.20s)
    exec.go:146: test timed out while running command: /tmp/workdir/tmp/go-build2241571717/testprogcgo.exe NeedmDeadlock
    crash_test.go:58: /tmp/workdir/tmp/go-build2241571717/testprogcgo.exe NeedmDeadlock: signal: quit
    crash_cgo_test.go:714: want OK
        , got 

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-01-26 07:17 darwin-amd64-10_15 go@cea70301 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.01s)
    crash_test.go:58: /tmp/buildlet/tmp/go-build4119296738/testprogcgo.exe NeedmDeadlock: signal: segmentation fault
    crash_cgo_test.go:716: want OK
        , got 
2023-01-26 07:17 darwin-amd64-11_0 go@cea70301 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.01s)
    crash_test.go:58: /tmp/buildlet/tmp/go-build2556092564/testprogcgo.exe NeedmDeadlock: signal: segmentation fault
    crash_cgo_test.go:716: want OK
        , got 
2023-01-26 10:15 darwin-amd64-10_15 go@4df10fba runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.01s)
    crash_test.go:58: /tmp/buildlet/tmp/go-build1310876794/testprogcgo.exe NeedmDeadlock: signal: segmentation fault
    crash_cgo_test.go:716: want OK
        , got 
2023-01-26 10:15 darwin-amd64-11_0 go@4df10fba runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.02s)
    crash_test.go:58: /tmp/buildlet/tmp/go-build4292740019/testprogcgo.exe NeedmDeadlock: signal: segmentation fault
    crash_cgo_test.go:716: want OK
        , got 

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-02-28 01:46 linux-s390x-ibm go@aaace6dd runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (5.48s)
    crash_test.go:58: /data/golang/workdir/tmp/go-build1781243837/testprogcgo.exe NeedmDeadlock: exit status 1
    crash_cgo_test.go:716: want OK
        , got Hung for 5 seconds

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-03-24 16:00 netbsd-arm-bsiegert go@ef0dedce runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.08s)
    crash_cgo_test.go:716: /var/gobuilder/buildlet/tmp/go-build3741504798/testprogcgo.exe NeedmDeadlock: exit status 2
    crash_cgo_test.go:719: want OK
        , got signal 11 received on thread with no signal stack
        fatal error: non-Go code disabled sigaltstack

        runtime stack:
        runtime.throw({0x174cb5, 0x20})
        	/var/gobuilder/buildlet/go/src/runtime/panic.go:1076 +0x4c fp=0x43cc90 sp=0x43cc7c pc=0x4f6ac
        runtime.noSignalStack(0xb)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:1032 +0x68 fp=0x43cc9c sp=0x43cc90 pc=0x69b5c
        runtime.adjustSignalStack(0xb, 0x42e000, 0x43cce4)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:590 +0x254 fp=0x43cccc sp=0x43cc9c pc=0x68b24
        runtime.sigtrampgo(0xb, 0x43cd38, 0x43cdb8)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:480 +0xc4 fp=0x43cd04 sp=0x43cccc pc=0x6870c
        runtime.sigtramp()
        	/var/gobuilder/buildlet/go/src/runtime/sys_netbsd_arm.s:306 +0x2c fp=0x43cd18 sp=0x43cd04 pc=0x88d1c

watchflakes

@cherrymui
Copy link
Member

The failure on 2023-03-24 is due to CL 392854 and is fixed with CL 479255.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-03-24 18:14 netbsd-arm-bsiegert go@2716dfd9 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.02s)
    crash_cgo_test.go:716: /var/gobuilder/buildlet/tmp/go-build1118342320/testprogcgo.exe NeedmDeadlock: exit status 2
    crash_cgo_test.go:719: want OK
        , got panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-03-24 17:48 netbsd-arm-bsiegert go@59d7c693 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.09s)
    crash_cgo_test.go:716: /var/gobuilder/buildlet/tmp/go-build632147128/testprogcgo.exe NeedmDeadlock: exit status 2
    crash_cgo_test.go:719: want OK
        , got signal 11 received on thread with no signal stack
        fatal error: non-Go code disabled sigaltstack

        runtime stack:
        runtime.throw({0x174cb5, 0x20})
        	/var/gobuilder/buildlet/go/src/runtime/panic.go:1076 +0x4c fp=0x43cc90 sp=0x43cc7c pc=0x4f6ac
        runtime.noSignalStack(0xb)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:1032 +0x68 fp=0x43cc9c sp=0x43cc90 pc=0x69b5c
        runtime.adjustSignalStack(0xb, 0x42e000, 0x43cce4)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:590 +0x254 fp=0x43cccc sp=0x43cc9c pc=0x68b24
        runtime.sigtrampgo(0xb, 0x43cd38, 0x43cdb8)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:480 +0xc4 fp=0x43cd04 sp=0x43cccc pc=0x6870c
        runtime.sigtramp()
        	/var/gobuilder/buildlet/go/src/runtime/sys_netbsd_arm.s:306 +0x2c fp=0x43cd18 sp=0x43cd04 pc=0x88d1c

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-03-31 19:15 linux-arm-aws go@99276aeb runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.01s)
    crash_cgo_test.go:722: /workdir/tmp/go-build590000508/testprogcgo.exe NeedmDeadlock: signal: segmentation fault (core dumped)
    crash_cgo_test.go:725: want OK
        , got 

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-03-31 19:15 netbsd-arm-bsiegert go@99276aeb runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.07s)
    crash_cgo_test.go:722: /var/gobuilder/buildlet/tmp/go-build646227022/testprogcgo.exe NeedmDeadlock: exit status 2
    crash_cgo_test.go:725: want OK
        , got signal 11 received on thread with no signal stack
        fatal error: non-Go code disabled sigaltstack

        runtime stack:
        runtime.throw({0x176019, 0x20})
        	/var/gobuilder/buildlet/go/src/runtime/panic.go:1076 +0x4c fp=0x43cc90 sp=0x43cc7c pc=0x4f6e0
        runtime.noSignalStack(0xb)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:1036 +0x68 fp=0x43cc9c sp=0x43cc90 pc=0x69b6c
        runtime.adjustSignalStack(0xb, 0x42e000, 0x43cce4)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:590 +0x254 fp=0x43cccc sp=0x43cc9c pc=0x68b28
        runtime.sigtrampgo(0xb, 0x43cd38, 0x43cdb8)
        	/var/gobuilder/buildlet/go/src/runtime/signal_unix.go:480 +0xc4 fp=0x43cd04 sp=0x43cccc pc=0x68710
        runtime.sigtramp()
        	/var/gobuilder/buildlet/go/src/runtime/sys_netbsd_arm.s:306 +0x2c fp=0x43cd18 sp=0x43cd04 pc=0x8934c

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-05-31 19:15 linux-s390x-ibm go@3cea9e68 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (5.05s)
    crash_cgo_test.go:745: /data/golang/workdir/tmp/go-build1347411103/testprogcgo.exe NeedmDeadlock: exit status 1
    crash_cgo_test.go:748: want OK
        , got Hung for 5 seconds

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-08-22 19:18 linux-s390x-ibm-race go@3e73802c runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (5.77s)
    crash_cgo_test.go:749: /data/golang/workdir/tmp/go-build111191324/testprogcgo.exe NeedmDeadlock: exit status 1
    crash_cgo_test.go:752: want OK
        , got Hung for 5 seconds

panic: test timed out after 6m0s
running tests:
	TestGoroutineParallelism2 (2m44s)

goroutine 23830 [running]:
...

goroutine 23842 [running]:
	goroutine running on other thread; stack unavailable
created by runtime_test.testGoroutineParallelism2.func2 in goroutine 23791
	/data/golang/workdir/go/src/runtime/proc_test.go:213 +0x92

goroutine 23793 [running]:
	goroutine running on other thread; stack unavailable
created by runtime_test.testGoroutineParallelism2.func2 in goroutine 23791
	/data/golang/workdir/go/src/runtime/proc_test.go:213 +0x92

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-09-12 17:08 netbsd-arm-bsiegert go@4f9fe6d5 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.00s)
    crash_cgo_test.go:749: building testprogcgo []: exit status 1
        # runtime/testdata/testprogcgo
        In file included from /usr/include/ucontext.h:36:0,
                         from stackswitch.c:16:
        /usr/include/sys/ucontext.h:44:2: error: unknown type name 'stack_t'
          stack_t  uc_stack; /* the stack used by this context */
          ^~~~~~~
        stackswitch.c: In function 'stackSwitchThread':
        stackswitch.c:68:22: error: request for member 'ss_sp' in something not a structure or union
          uctx_switch.uc_stack.ss_sp = stack1;
                              ^
        stackswitch.c:69:22: error: request for member 'ss_size' in something not a structure or union
          uctx_switch.uc_stack.ss_size = STACK_SIZE;
                              ^
        stackswitch.c:82:22: error: request for member 'ss_sp' in something not a structure or union
          uctx_switch.uc_stack.ss_sp = stack2;
                              ^
        stackswitch.c:83:22: error: request for member 'ss_size' in something not a structure or union
          uctx_switch.uc_stack.ss_size = STACK_SIZE;
                              ^
2023-09-12 18:14 netbsd-arm-bsiegert go@5cc1e99f runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.00s)
    crash_cgo_test.go:749: building testprogcgo []: exit status 1
        # runtime/testdata/testprogcgo
        In file included from /usr/include/ucontext.h:36:0,
                         from stackswitch.c:16:
        /usr/include/sys/ucontext.h:44:2: error: unknown type name 'stack_t'
          stack_t  uc_stack; /* the stack used by this context */
          ^~~~~~~
        stackswitch.c: In function 'stackSwitchThread':
        stackswitch.c:68:22: error: request for member 'ss_sp' in something not a structure or union
          uctx_switch.uc_stack.ss_sp = stack1;
                              ^
        stackswitch.c:69:22: error: request for member 'ss_size' in something not a structure or union
          uctx_switch.uc_stack.ss_size = STACK_SIZE;
                              ^
        stackswitch.c:82:22: error: request for member 'ss_sp' in something not a structure or union
          uctx_switch.uc_stack.ss_sp = stack2;
                              ^
        stackswitch.c:83:22: error: request for member 'ss_size' in something not a structure or union
          uctx_switch.uc_stack.ss_size = STACK_SIZE;
                              ^

watchflakes

@seankhliao seankhliao removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 18, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2023-09-12 17:47 netbsd-arm-bsiegert go@9f5a2cf6 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.00s)
    crash_cgo_test.go:749: building testprogcgo []: exit status 1
        # runtime/testdata/testprogcgo
        In file included from /usr/include/ucontext.h:36:0,
                         from stackswitch.c:16:
        /usr/include/sys/ucontext.h:44:2: error: unknown type name 'stack_t'
          stack_t  uc_stack; /* the stack used by this context */
          ^~~~~~~
        stackswitch.c: In function 'stackSwitchThread':
        stackswitch.c:68:22: error: request for member 'ss_sp' in something not a structure or union
          uctx_switch.uc_stack.ss_sp = stack1;
                              ^
        stackswitch.c:69:22: error: request for member 'ss_size' in something not a structure or union
          uctx_switch.uc_stack.ss_size = STACK_SIZE;
                              ^
        stackswitch.c:82:22: error: request for member 'ss_sp' in something not a structure or union
          uctx_switch.uc_stack.ss_sp = stack2;
                              ^
        stackswitch.c:83:22: error: request for member 'ss_size' in something not a structure or union
          uctx_switch.uc_stack.ss_size = STACK_SIZE;
                              ^

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2024-01-10 17:35 netbsd-arm-bsiegert go@e9b3ff15 runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.14s)
    crash_cgo_test.go:750: /scratch/gobuilder/buildlet/tmp/go-build2263110711/testprogcgo.exe NeedmDeadlock: exit status 2
    crash_cgo_test.go:753: want OK
        , got signal 20 received on thread with no signal stack
        fatal error: non-Go code disabled sigaltstack

        runtime stack:
        runtime.throw({0x18e5c1, 0x20})
        	/scratch/gobuilder/buildlet/go/src/runtime/panic.go:1023 +0x4c fp=0x444c8c sp=0x444c78 pc=0x53f54
        runtime.noSignalStack(0x14)
...
        runtime.gopark(0x193ea4, 0x490000, 0x13, 0xe, 0x1)
        	/scratch/gobuilder/buildlet/go/src/runtime/proc.go:402 +0x104 fp=0x4307a4 sp=0x430790 pc=0x57430
        time.Sleep(0x12a05f200)
        	/scratch/gobuilder/buildlet/go/src/runtime/time.go:195 +0x158 fp=0x4307c0 sp=0x4307a4 pc=0x8fb0c
        main.NeedmDeadlock.func1()
        	/scratch/gobuilder/buildlet/go/src/runtime/testdata/testprogcgo/needmdeadlock.go:89 +0x24 fp=0x4307ec sp=0x4307c0 pc=0x150c54
        runtime.goexit({})
        	/scratch/gobuilder/buildlet/go/src/runtime/asm_arm.s:859 +0x4 fp=0x4307ec sp=0x4307ec pc=0x91d44
        created by main.NeedmDeadlock in goroutine 1
        	/scratch/gobuilder/buildlet/go/src/runtime/testdata/testprogcgo/needmdeadlock.go:88 +0x1c

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestNeedmDeadlock"
2024-02-17 06:03 netbsd-arm-bsiegert go@86a32d6d runtime.TestNeedmDeadlock (log)
--- FAIL: TestNeedmDeadlock (0.13s)
    crash_cgo_test.go:750: /scratch/gobuilder/buildlet/tmp/go-build1471636622/testprogcgo.exe NeedmDeadlock: exit status 2
    crash_cgo_test.go:753: want OK
        , got signal 20 received on thread with no signal stack
        fatal error: non-Go code disabled sigaltstack

        runtime stack:
        runtime.throw({0x18e14c, 0x20})
        	/scratch/gobuilder/buildlet/go/src/runtime/panic.go:1021 +0x4c fp=0x444c24 sp=0x444c10 pc=0x539ec
        runtime.noSignalStack(0x14)
...
        runtime.gopark(0x193a30, 0x580000, 0x13, 0xe, 0x1)
        	/scratch/gobuilder/buildlet/go/src/runtime/proc.go:402 +0x104 fp=0x4307a4 sp=0x430790 pc=0x56ec0
        time.Sleep(0x12a05f200)
        	/scratch/gobuilder/buildlet/go/src/runtime/time.go:195 +0x158 fp=0x4307c0 sp=0x4307a4 pc=0x8f8ec
        main.NeedmDeadlock.func1()
        	/scratch/gobuilder/buildlet/go/src/runtime/testdata/testprogcgo/needmdeadlock.go:89 +0x24 fp=0x4307ec sp=0x4307c0 pc=0x150920
        runtime.goexit({})
        	/scratch/gobuilder/buildlet/go/src/runtime/asm_arm.s:859 +0x4 fp=0x4307ec sp=0x4307ec pc=0x91b24
        created by main.NeedmDeadlock in goroutine 1
        	/scratch/gobuilder/buildlet/go/src/runtime/testdata/testprogcgo/needmdeadlock.go:88 +0x1c

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

4 participants