Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServerShutdown failures #56421

Open
gopherbot opened this issue Oct 25, 2022 · 6 comments
Open

net/http: TestServerShutdown failures #56421

gopherbot opened this issue Oct 25, 2022 · 6 comments
Assignees
@neild
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@gopherbot
Copy link

gopherbot commented Oct 25, 2022 

#!watchflakes
post <- pkg == "net/http" && test == "TestServerShutdown"

Issue created automatically to collect these failures.

Example (log):

2022/10/25 00:24:18 http2: server: error reading preface from client 127.0.0.1:58560: bogus greeting "CONNECT golang.fake.tld:"
2022/10/25 00:24:18 http2: server: error reading preface from client 127.0.0.1:59626: bogus greeting "CONNECT golang.fake.tld:"
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:57220: read tcp 127.0.0.1:43019->127.0.0.1:57220: i/o timeout
--- FAIL: TestServerShutdown (0.00s)
    --- FAIL: TestServerShutdown/h2 (0.06s)
        serve_test.go:5564: second request should fail. server should be shut down
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:37530: EOF
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:42388: EOF
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55964: write tcp 127.0.0.1:39597->127.0.0.1:55964: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55944: write tcp 127.0.0.1:39597->127.0.0.1:55944: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47390: write tcp 127.0.0.1:43357->127.0.0.1:47390: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55990: write tcp 127.0.0.1:39597->127.0.0.1:55990: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47416: write tcp 127.0.0.1:43357->127.0.0.1:47416: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47396: write tcp 127.0.0.1:43357->127.0.0.1:47396: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55978: write tcp 127.0.0.1:39597->127.0.0.1:55978: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47432: write tcp 127.0.0.1:43357->127.0.0.1:47432: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47440: write tcp 127.0.0.1:43357->127.0.0.1:47440: use of closed network connection

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 25, 2022
@gopherbot
Copy link
Author

gopherbot commented Oct 25, 2022

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestServerShutdown"
2022-10-25 00:18 linux-amd64-buster go@9fffcde1 net/http.TestServerShutdown (log) 
2022/10/25 00:24:18 http2: server: error reading preface from client 127.0.0.1:58560: bogus greeting "CONNECT golang.fake.tld:"
2022/10/25 00:24:18 http2: server: error reading preface from client 127.0.0.1:59626: bogus greeting "CONNECT golang.fake.tld:"
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:57220: read tcp 127.0.0.1:43019->127.0.0.1:57220: i/o timeout
--- FAIL: TestServerShutdown (0.00s)
    --- FAIL: TestServerShutdown/h2 (0.06s)
        serve_test.go:5564: second request should fail. server should be shut down
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:37530: EOF
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:42388: EOF
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55964: write tcp 127.0.0.1:39597->127.0.0.1:55964: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55944: write tcp 127.0.0.1:39597->127.0.0.1:55944: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47390: write tcp 127.0.0.1:43357->127.0.0.1:47390: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55990: write tcp 127.0.0.1:39597->127.0.0.1:55990: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47416: write tcp 127.0.0.1:43357->127.0.0.1:47416: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47396: write tcp 127.0.0.1:43357->127.0.0.1:47396: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:55978: write tcp 127.0.0.1:39597->127.0.0.1:55978: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47432: write tcp 127.0.0.1:43357->127.0.0.1:47432: use of closed network connection
2022/10/25 00:24:18 http: TLS handshake error from 127.0.0.1:47440: write tcp 127.0.0.1:43357->127.0.0.1:47440: use of closed network connection

— watchflakes

@bcmills
Copy link
Member

bcmills commented Oct 25, 2022

Is this a duplicate of #56036?

(Compare #38305, #54758 (comment).)

@gopherbot
Copy link
Author

gopherbot commented Nov 4, 2022

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestServerShutdown"
2022-10-27 01:24 dragonfly-amd64-622 go@612bb34a net/http.TestServerShutdown (log) 
2022/10/27 01:42:04 http2: server: error reading preface from client 127.0.0.1:49622: bogus greeting "CONNECT golang.fake.tld:"
2022/10/27 01:42:04 http2: server: error reading preface from client 127.0.0.1:58722: bogus greeting "CONNECT golang.fake.tld:"
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:53152: EOF
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:52184: EOF
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:49586: read tcp 127.0.0.1:64104->127.0.0.1:49586: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:50198: read tcp 127.0.0.1:64104->127.0.0.1:50198: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:64095: read tcp 127.0.0.1:64104->127.0.0.1:64095: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:57265: read tcp 127.0.0.1:64104->127.0.0.1:57265: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:60062: read tcp 127.0.0.1:64104->127.0.0.1:60062: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:52742: read tcp 127.0.0.1:64104->127.0.0.1:52742: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:63438: read tcp 127.0.0.1:61272->127.0.0.1:63438: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:59978: read tcp 127.0.0.1:61272->127.0.0.1:59978: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:50094: read tcp 127.0.0.1:61272->127.0.0.1:50094: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:59623: write tcp 127.0.0.1:61272->127.0.0.1:59623: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:59455: read tcp 127.0.0.1:61272->127.0.0.1:59455: use of closed network connection
2022/10/27 01:42:05 http: TLS handshake error from 127.0.0.1:55941: write tcp 127.0.0.1:64104->127.0.0.1:55941: use of closed network connection
--- FAIL: TestServerShutdown (0.00s)
    --- FAIL: TestServerShutdown/h1 (0.05s)
        serve_test.go:5564: second request should fail. server should be shut down
2022-10-31 20:45 linux-amd64-nounified go@76940b3e net/http.TestServerShutdown (log) 
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:53206: read tcp 127.0.0.1:43723->127.0.0.1:53206: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:53226: read tcp 127.0.0.1:43723->127.0.0.1:53226: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:36180: write tcp 127.0.0.1:45453->127.0.0.1:36180: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:53256: write tcp 127.0.0.1:43723->127.0.0.1:53256: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:53208: write tcp 127.0.0.1:43723->127.0.0.1:53208: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:53200: write tcp 127.0.0.1:43723->127.0.0.1:53200: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:53214: write tcp 127.0.0.1:43723->127.0.0.1:53214: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:36162: write tcp 127.0.0.1:45453->127.0.0.1:36162: use of closed network connection
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:54892: EOF
2022/10/31 20:54:56 http: TLS handshake error from 127.0.0.1:39626: EOF
2022/10/31 20:54:56 http2: server: error reading preface from client 127.0.0.1:59452: bogus greeting "CONNECT golang.fake.tld:"
2022/10/31 20:54:56 http2: server: error reading preface from client 127.0.0.1:37450: bogus greeting "CONNECT golang.fake.tld:"
--- FAIL: TestServerShutdown (0.00s)
    --- FAIL: TestServerShutdown/h2 (0.05s)
        serve_test.go:5564: second request should fail. server should be shut down

— watchflakes

@gopherbot
Copy link
Author

gopherbot commented Nov 17, 2022

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestServerShutdown"
2022-11-15 00:27 linux-amd64 go@f977ffe8 net/http.TestServerShutdown (log) 
2022/11/15 00:34:39 http2: server: error reading preface from client 127.0.0.1:54838: bogus greeting "CONNECT golang.fake.tld:"
2022/11/15 00:34:39 http2: server: error reading preface from client 127.0.0.1:44904: bogus greeting "CONNECT golang.fake.tld:"
--- FAIL: TestServerShutdown (0.00s)
    --- FAIL: TestServerShutdown/h1 (0.05s)
        serve_test.go:5633: second request should fail. server should be shut down
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:47584: EOF
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:59368: EOF
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:43416: read tcp 127.0.0.1:33251->127.0.0.1:43416: use of closed network connection
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:43402: read tcp 127.0.0.1:33251->127.0.0.1:43402: use of closed network connection
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:38466: read tcp 127.0.0.1:32867->127.0.0.1:38466: use of closed network connection
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:38406: read tcp 127.0.0.1:32867->127.0.0.1:38406: use of closed network connection
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:38492: write tcp 127.0.0.1:32867->127.0.0.1:38492: use of closed network connection
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:38436: write tcp 127.0.0.1:32867->127.0.0.1:38436: use of closed network connection
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:38488: write tcp 127.0.0.1:32867->127.0.0.1:38488: use of closed network connection
2022/11/15 00:34:39 http: TLS handshake error from 127.0.0.1:38476: write tcp 127.0.0.1:32867->127.0.0.1:38476: use of closed network connection

— watchflakes

@bcmills
Copy link
Member

bcmills commented Nov 17, 2022

(attn @neild)

@neild neild mentioned this issue Nov 17, 2022
Closed
@neild
Copy link
Contributor

neild commented Nov 17, 2022

Is this a duplicate of #56036?

Yes, due to the test being renamed from TestServerShutdown_h2 to TestServerShutdown/h2 in the Great Test Refactoring.

@neild neild self-assigned this Nov 18, 2022
@seankhliao seankhliao added this to the Unplanned milestone Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@neild @bcmills @gopherbot @seankhliao