Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: silly typo in documentation #56479

Closed
seebs opened this issue Oct 28, 2022 · 2 comments
Closed

testing: silly typo in documentation #56479

seebs opened this issue Oct 28, 2022 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge

Comments

@seebs
Copy link
Contributor

seebs commented Oct 28, 2022

What version of Go are you using (go version)?

$ go version
1.19.2

Does this issue reproduce with the latest release?

y

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

Read the docs.

What did you expect to see?

Fewer typos.

What did you see instead?

In the FuzzJSONMarshaling example:

t.Error("Marshal: %v", err)

Either this shouldn't have the "%v", or it should be t.Errorf.
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Oct 28, 2022
@ianlancetaylor
Copy link
Member

Thanks, sending a CL.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/446275 mentions this issue: testing: change Error to Errorf in comment

romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
@ianlancetaylor @romaindoumenc
testing: change Error to Errorf in comment
24a8fb1 
Fixes golang#56479

Change-Id: I1d97eb3ea97304e429e178ad05cb9f861b2bce84
Reviewed-on: https://go-review.googlesource.com/c/go/+/446275
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
@golang golang locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seebs @ianlancetaylor @gopherbot