-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: update subrepo list #56482
Comments
Suggested changes make sense to me. Not sure whether oauth2 and term were intentionally omitted, since they have existed for some time. mod and vuln are new enough that I suspect they just post-dated the original list. CC @jamalc, who appears to have some context on this page. |
If the list is intentionally not exhaustive, I would suggest noting this on the page. I ended up reinventing the wheel on some modules-related stuff because I didn't know that |
Change https://go.dev/cl/476202 mentions this issue: |
This CL includes several changes related to the sub-repositories page: - remove x/blog, which has been cleared out - add x/mod, x/oauth2, x/term, x/vuln, and x/website - sort x/exp alphabetically, as others; no need for it to be an outlier - note that the list is not exhaustive, and redirect to go.googlesource.com for the full list - remove stale suggestion to use `go get`; this is unnecessary, and wrong for installing binaries - add a footer link to the sub-repositories page Updates golang/go#56482 Change-Id: I87e7df911ba692c15e99ab9b28c66e63e32e0073 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/476202 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jamal Carvalho <jamal@golang.org>
It took me a while to get to this, sorry. I've made most of the recommended changes here. I also included x/website in the list. @jamalc you mentioned making this page more accessible. It seemed OK to me, though I didn't try it out with a screen reader. Can we close this issue and handle accessibility more holistically in a separate issue? (I think we have plans to do a more widespread accessibility analysis) |
Yes, I meant "easy to be reached" and we will address web accessibility more holistically later this year. |
Oh. That makes sense now that I re-read your comment! Ok, then I'll close this now. |
What is the URL of the page with the issue?
https://pkg.go.dev/golang.org/x
Currently the sub repo page lists the following repos
"blog" should be removed, the repo has been cleared out
"mod", "oauth2", "term", and "vuln" seem to be suitable candidates for adding to the list
"exp" could be moved up to follow alphabetical order?
Could a link to this page be added to the footer under Packages / Standard library?
The text was updated successfully, but these errors were encountered: