Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text/template: tests in exec_test.go: T.ComplexZero is float64 instead of complex128 #5649

Closed
gopherbot opened this issue Jun 6, 2013 · 3 comments
Assignees
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 6, 2013

by arnehormann:

Problem:
Tests for complex variables don't test what they are meant to.

The culprit is declared in
https://code.google.com/p/go/source/browse/src/pkg/text/template/exec_test.go#27

The non-complex float64 is then used in tests
https://code.google.com/p/go/source/browse/src/pkg/text/template/exec_test.go#358
https://code.google.com/p/go/source/browse/src/pkg/text/template/exec_test.go#431

In this case, it would probably be better to test against non-zero values.
@robpike
Copy link
Contributor

@robpike robpike commented Jun 6, 2013

Comment 1:

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @robpike.

Status changed to Accepted.

@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 2:

Labels changed: added go1.2.

@robpike
Copy link
Contributor

@robpike robpike commented Jul 31, 2013

Comment 3:

This issue was closed by revision 5fea8c0.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.