-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vuln/cmd/govulncheck: add some progress output #56501
Comments
Is it also possible to add some logging in x/vuln/vulncheck too? |
We could do that. For instance, we can have a, say, Verbose flag in vulncheck.Config that logs major vulncheck steps. |
same as #56101 ? |
Yes, will close the former one to keep the current discussion flowing. |
Change https://go.dev/cl/463099 mentions this issue: |
Change https://go.dev/cl/463105 mentions this issue: |
Otherwise, the JSON output is corrupted. Updates golang/go#56501 Updates golang/go#56207 Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70 Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
There are two progress output messages: one for source and one for binaries. The latter one is simpler since the binary analysis is almost instantaneous. Fixes golang/go#56501 Updates golang/go#56207 Change-Id: I381c8ef3b7db9c87c52ef6b2132b79be940b8b3d Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463099 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
Otherwise, the JSON output is corrupted. Updates golang/go#56501 Updates golang/go#56207 Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70 Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
There are two progress output messages: one for source and one for binaries. The latter one is simpler since the binary analysis is almost instantaneous. Fixes golang/go#56501 Updates golang/go#56207 Change-Id: I381c8ef3b7db9c87c52ef6b2132b79be940b8b3d Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463099 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
Otherwise, the JSON output is corrupted. Updates golang/go#56501 Updates golang/go#56207 Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70 Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
There are two progress output messages: one for source and one for binaries. The latter one is simpler since the binary analysis is almost instantaneous. Fixes golang/go#56501 Updates golang/go#56207 Change-Id: I381c8ef3b7db9c87c52ef6b2132b79be940b8b3d Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463099 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
Otherwise, the JSON output is corrupted. Updates golang/go#56501 Updates golang/go#56207 Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70 Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
Make govulncheck a bit more transparent by printing some progress output. Initially, we can write something like
"Analyzing X specified packages and Y of their transitive dependencies..."
The text was updated successfully, but these errors were encountered: