Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln/cmd/govulncheck: add some progress output #56501

Closed
zpavlinovic opened this issue Oct 31, 2022 · 6 comments
Closed

x/vuln/cmd/govulncheck: add some progress output #56501

zpavlinovic opened this issue Oct 31, 2022 · 6 comments
Assignees
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone

Comments

@zpavlinovic
Copy link
Contributor

Make govulncheck a bit more transparent by printing some progress output. Initially, we can write something like

"Analyzing X specified packages and Y of their transitive dependencies..."

@zpavlinovic zpavlinovic added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Oct 31, 2022
@zpavlinovic zpavlinovic added this to the vuln/2022 milestone Oct 31, 2022
@zpavlinovic zpavlinovic self-assigned this Oct 31, 2022
@seankhliao seankhliao changed the title golang.org/x/vuln/cmd/govulncheck: add some progress output x/vuln/cmd/govulncheck: add some progress output Nov 1, 2022
@hyangah
Copy link
Contributor

hyangah commented Nov 1, 2022

Is it also possible to add some logging in x/vuln/vulncheck too?

@zpavlinovic
Copy link
Contributor Author

We could do that. For instance, we can have a, say, Verbose flag in vulncheck.Config that logs major vulncheck steps.

@seankhliao
Copy link
Member

same as #56101 ?

@zpavlinovic
Copy link
Contributor Author

Yes, will close the former one to keep the current discussion flowing.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/463099 mentions this issue: cmd/govulncheck: add progress output

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/463105 mentions this issue: cmd/govulncheck: print progress messages only in text mode

gopherbot pushed a commit to golang/vuln that referenced this issue Jan 25, 2023
Otherwise, the JSON output is corrupted.

Updates golang/go#56501
Updates golang/go#56207

Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
There are two progress output messages: one for source and one for binaries.
The latter one is simpler since the binary analysis is almost instantaneous.

Fixes golang/go#56501
Updates golang/go#56207

Change-Id: I381c8ef3b7db9c87c52ef6b2132b79be940b8b3d
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463099
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
Otherwise, the JSON output is corrupted.

Updates golang/go#56501
Updates golang/go#56207

Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
There are two progress output messages: one for source and one for binaries.
The latter one is simpler since the binary analysis is almost instantaneous.

Fixes golang/go#56501
Updates golang/go#56207

Change-Id: I381c8ef3b7db9c87c52ef6b2132b79be940b8b3d
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463099
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
Otherwise, the JSON output is corrupted.

Updates golang/go#56501
Updates golang/go#56207

Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
There are two progress output messages: one for source and one for binaries.
The latter one is simpler since the binary analysis is almost instantaneous.

Fixes golang/go#56501
Updates golang/go#56207

Change-Id: I381c8ef3b7db9c87c52ef6b2132b79be940b8b3d
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463099
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
Otherwise, the JSON output is corrupted.

Updates golang/go#56501
Updates golang/go#56207

Change-Id: I97a7dff99f1a06d001280079ccccc2fed211de70
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/463105
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@golang golang locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Development

No branches or pull requests

4 participants