Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/jsonrpc2_v2: frequent flakes on the -race builders #56510

Closed
findleyr opened this issue Nov 1, 2022 · 4 comments
Closed

x/tools/internal/jsonrpc2_v2: frequent flakes on the -race builders #56510

findleyr opened this issue Nov 1, 2022 · 4 comments
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Nov 1, 2022

This flake is very prevalent following recent changes to the jsonrpc2_v2 package:

panic: jsonrpc2: &jsonrpc2_test.handler{conn:(*jsonrpc2.Connection)(0xc00042c6c0), accumulator:0, waiters:(chan map[string]chan struct {})(0xc00042acc0), calls:map[string]*jsonrpc2.AsyncCall{}} produced a duplicate "wait" Response

goroutine 59 [running]:
golang.org/x/tools/internal/jsonrpc2_v2.(*Connection).internalErrorf(0xc00042c6c0, {0x6c8ab7, 0x24}, {0xc000177e18, 0x2, 0x2})
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:724 +0x21b
golang.org/x/tools/internal/jsonrpc2_v2.(*Connection).processResult(0xc000412900?, {0x68e1e0, 0xc000412900}, 0xc000165c80, {0x0, 0x0}, {0x70b5c0?, 0xc0000a82a0?})
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:631 +0xe53
golang.org/x/tools/internal/jsonrpc2_v2.(*Connection).handleAsync(0xc00042c6c0)
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:613 +0x65
created by golang.org/x/tools/internal/jsonrpc2_v2.(*Connection).acceptRequest.func2
	/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:576 +0x28f

CC @bcmills @adonovan

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Nov 1, 2022
@gopherbot gopherbot added this to the Unreleased milestone Nov 1, 2022
@bcmills
Copy link
Contributor

bcmills commented Nov 1, 2022

Oops, I see the bug. Missed a return here. I'll send a CL shortly.

@bcmills bcmills self-assigned this Nov 1, 2022
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Nov 1, 2022
@gopherbot
Copy link

Change https://go.dev/cl/446857 mentions this issue: internal/jsonrcp2_v2: disable tests in order to unblock TryBots

@findleyr
Copy link
Contributor Author

findleyr commented Nov 1, 2022

Thanks, this is preventing my landing a critical fix (https://go.dev/cl/446815). I was going to turn off these tests but if you can quickly fix forward, that works as well.

@gopherbot
Copy link

Change https://go.dev/cl/446859 mentions this issue: internal/jsonrpc2_v2: add a missing early return in handleAsync

@golang golang locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants