testing: expose common struct as interface

I recently found myself doing the following in one of our test suites

func Foo[T testing.T | testing.B | testing.F](t *T) *Bar {
   // test prep stuff

	var cleanupFn func(func())
	switch any(t).(type) {
	case *testing.T:
		cleanupFn = any(t).(*testing.T).Cleanup
	case *testing.B:
		cleanupFn = any(t).(*testing.B).Cleanup
	case *testing.F:
		cleanupFn = any(t).(*testing.F).Cleanup
	default:
		log.Fatalf("Error: unsupported type %T", t)
	}
	
	cleanupFn(func(){
      // test cleanup stuff
    })

The cleanup function is common to all of these and is part of the common struct, which is embedded in each of testingT, testing.B, and testing.F.

I was wondering if common could potentially be exposed as an interface?

I'm happy to take a first stab at the PR if this is something the library mainteras would be open to, unless there's a technical reason this shouldn't be the case. Please lmk!

https://pkg.go.dev/testing#TB

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For questions please refer to https://github.com/golang/go/wiki/Questions

@seankhliao

@seankhliao This is a proposal though. I'm proposing to make an interface for the common struct under testing. I didn't want to put the effort into implementation before getting a 👍 so I don't waste time implementing.

@Olshansk

@Olshansk @seankhliao's message includes a link to the already-existing interface: https://pkg.go.dev/testing#TB.

@seankhliao

That's exactly what I needed. Sorry for not RTFM the first time @seankhliao!

Navigation Menu

Repository navigation

testing: expose common struct as interface #56516

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

testing: expose common struct as interface #56516

Description

Activity

seankhliao commented on Nov 1, 2022

Olshansk commented on Nov 2, 2022

cespare commented on Nov 2, 2022

Olshansk commented on Nov 3, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions