-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: TestScripts/svn fails if TZ database not installed #56527
Comments
The These are the offending lines: > cmp stdout .svn-log
diff stdout .svn-log
--- stdout
+++ .svn-log
@@ -1,5 +1,5 @@
------------------------------------------------------------------------
-r1 | rsc | 2017-09-22 01:12:45 +0000 (Fri, 22 Sep 2017) | 3 lines
+r1 | rsc | 2017-09-21 21:12:45 -0400 (Thu, 21 Sep 2017) | 3 lines The first date timezone is UTC and has been formatted by |
I believe that we can fix this issue by changing |
Change https://go.dev/cl/447335 mentions this issue: |
That seems like a fine solution as long as the tests that use that repo don't depend on that timezone information. |
`TestScripts/svn` test suite fails if the host does not have a TZ database installed. This CL updates those tests so SVN formats dates using UTC, which don't require a TZ database. Fixes golang#56527 Change-Id: I20f3c03c3cedd7d748f4623dddc66bd04d1df318 Reviewed-on: https://go-review.googlesource.com/c/go/+/447335 Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Quim Muntal <quimmuntal@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Auto-Submit: Bryan Mills <bcmills@google.com>
Change https://go.dev/cl/447795 mentions this issue: |
Change https://go.dev/cl/447935 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Only in tip
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
go test -run TestScripts/svn/hello -count 1 ./cmd/go/internal/vcweb/vcstest
What did you expect to see?
ok cmd/go/internal/vcweb/vcstest 0.155s
What did you see instead?
Additional info
test1-svn-git.txt
andtest2-svn-git.txt
.vcs-test.golang.org
to a test-local server #27494.svn
but withouttzdata
.The text was updated successfully, but these errors were encountered: