Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: boringcrypto restricts RSA key sizes to 2048 and 3072 [1.19 backport] #56672

Closed
gopherbot opened this issue Nov 9, 2022 · 2 comments
Closed

crypto/tls: boringcrypto restricts RSA key sizes to 2048 and 3072 [1.19 backport] #56672

gopherbot opened this issue Nov 9, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.19.4

Comments

@gopherbot
Copy link

@rsc requested issue #41147 to be considered for backport to the next 1.19 minor release.

@gopherbot please backport
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 9, 2022
@gopherbot gopherbot mentioned this issue Nov 9, 2022
Closed
@gopherbot gopherbot added this to the Go1.19.4 milestone Nov 9, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/449016 mentions this issue: [release-branch.go1.19] crypto/x509: allow BoringCrypto to use 4096-bit keys

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Nov 9, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 9, 2022
@gopherbot
Copy link
Author

Closed by merging 861ba02 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Nov 13, 2022
@rsc
[release-branch.go1.19] crypto/x509: allow BoringCrypto to use 4096-b…
861ba02 
…it keys

FIPS-140 has been updated to allow 4096-bit RSA keys.
Allow them in certificate processing.

For #41147.
Fixes #56672.

Change-Id: I4c6bcb1b137a200dfe70cebc605ae57f49871184
Reviewed-on: https://go-review.googlesource.com/c/go/+/447655
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/449016
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@rsc @andrew-d
[release-branch.go1.19] crypto/x509: allow BoringCrypto to use 4096-b…
a8ce6fd 
…it keys

FIPS-140 has been updated to allow 4096-bit RSA keys.
Allow them in certificate processing.

For golang#41147.
Fixes golang#56672.

Change-Id: I4c6bcb1b137a200dfe70cebc605ae57f49871184
Reviewed-on: https://go-review.googlesource.com/c/go/+/447655
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/449016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.19.4
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot