Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: use cloud build to update docker images #56673

Open
toothrot opened this issue Nov 9, 2022 · 3 comments
Open

x/build: use cloud build to update docker images #56673

toothrot opened this issue Nov 9, 2022 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@toothrot
Copy link
Contributor

toothrot commented Nov 9, 2022

A number of our buildlets on Google Cloud Platform run in docker images. Rather than running manual commands for each image, we could kick off periodic cloud build jobs to build images, and then update builder configurations as necessary.

Regularly updating images would also help us match what user's are more likely using, and also allow us to create builders that are up to date with upcoming OS releases.

@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 9, 2022
@toothrot toothrot added this to the Backlog milestone Nov 9, 2022
@toothrot toothrot self-assigned this Nov 9, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 9, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/449037 mentions this issue: env/linux-x86-sid: add cloudbuild configuration

gopherbot pushed a commit to golang/build that referenced this issue Nov 9, 2022
Also, update to the latest tag rather than one from 2019. This is in
preparation for changing the host config to use a specific image tag
instead of baking the image tag into every docker image.

This change will allow us to keep a separate 'cloudbuild' tag from the
tag used for the main bulder. This tag can be updated weekly, allowing
us to run a second builder in parallel to determine when we want to
update to a newer image.

For golang/go#56673

Change-Id: I906a95b447949deba0b108b3009c440aa5c31171
Reviewed-on: https://go-review.googlesource.com/c/build/+/449037
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@joedian joedian moved this to In Progress in Go Release Nov 15, 2022
@dmitshur dmitshur moved this from In Progress to Planned in Go Release Dec 6, 2022
@cagedmantis cagedmantis self-assigned this Jan 3, 2023
@cagedmantis cagedmantis moved this from Planned to In Progress in Go Release Jan 3, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/460355 mentions this issue: cmd/coordinator: deploy the coordinator with Cloud Build

@cagedmantis cagedmantis removed their assignment Jan 17, 2023
@cagedmantis cagedmantis moved this from In Progress to Planned in Go Release Jan 17, 2023
@dmitshur dmitshur modified the milestones: Backlog, Unreleased Mar 2, 2023
gopherbot pushed a commit to golang/build that referenced this issue Mar 2, 2023
This changes where the container image is build and publishes it to
the container registry. Cloud Build is used to create and publish the
coordinator container image.

Updates golang/go#56673

Change-Id: I6811c59fe06f7507e576baf10b12fc09d1212174
Reviewed-on: https://go-review.googlesource.com/c/build/+/460355
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/479836 mentions this issue: cmd/coordinator: add the project flag to the image build

gopherbot pushed a commit to golang/build that referenced this issue Mar 28, 2023
This change specifies the project in the cloud build image command.

For golang/go#56673

Change-Id: Ib275c2b42d4cf0930b1ac56be876ce0683643b6e
Reviewed-on: https://go-review.googlesource.com/c/build/+/479836
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Planned
Development

No branches or pull requests

4 participants