Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: reenable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV with a different target #56708

Closed
mknyszek opened this issue Nov 11, 2022 · 7 comments
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Nov 11, 2022

Due to #56707 these tests were disabled. This issue tracks reenabling them with a different DNS target that works.

CC @neild

@mateusz834
Copy link
Contributor

mateusz834 commented Nov 11, 2022

We might use now email SRVs like: _submission._tcp.gmail.com

@mknyszek mknyszek added release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Nov 11, 2022
@mknyszek
Copy link
Contributor Author

mknyszek commented Nov 11, 2022

@gopherbot Please open backport a backport issue for Go 1.18 and Go 1.19 since the same workaround and test skips were applied there.

@gopherbot
Copy link

gopherbot commented Nov 11, 2022

Backport issue(s) opened: #56711 (for 1.18), #56712 (for 1.19).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 16, 2022
@cherrymui
Copy link
Member

cherrymui commented Nov 23, 2022

It is not a release blocker, but would be good to be done soon-ish. Thanks.

@neild neild self-assigned this Nov 23, 2022
@gopherbot
Copy link

gopherbot commented Nov 30, 2022

Change https://go.dev/cl/453861 mentions this issue: net: reenable SRV tests with _ldap._tcp.google.com

@gopherbot
Copy link

gopherbot commented Nov 30, 2022

Change https://go.dev/cl/454295 mentions this issue: [release-branch.go1.18] net: reenable SRV tests with _ldap._tcp.google.com

@gopherbot
Copy link

gopherbot commented Nov 30, 2022

Change https://go.dev/cl/454296 mentions this issue: [release-branch.go1.19] net: reenable SRV tests with _ldap._tcp.google.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

6 participants