Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: TestRacyOutput failures #56808

Closed
gopherbot opened this issue Nov 17, 2022 · 3 comments
Closed

testing: TestRacyOutput failures #56808

gopherbot opened this issue Nov 17, 2022 · 3 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.20

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "testing" && test == "TestRacyOutput"

Issue created automatically to collect these failures.

Example (log):

panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0x820e970, 0x94203b0, 0xe, 0x17, 0x2)
	/workdir/go/src/runtime/proc.go:381 +0x108 fp=0x9586684 sp=0x9586670 pc=0x8081e38
runtime.chanrecv(0x9420380, 0x9586703, 0x1)
	/workdir/go/src/runtime/chan.go:583 +0x3f4 fp=0x95866cc sp=0x9586684 pc=0x804d964
runtime.chanrecv1(0x9420380, 0x9586703)
	/workdir/go/src/runtime/chan.go:442 +0x1c fp=0x95866e0 sp=0x95866cc pc=0x804d53c
testing.(*T).Run(0x95ae2d0, {0x0, 0x0}, 0x9600050)
	/workdir/go/src/testing/testing.go:1629 +0x446 fp=0x9586744 sp=0x95866e0 pc=0x8147bd6
testing.TestRacyOutput(0x95ae1e0)
	/workdir/go/src/testing/sub_test.go:814 +0x2c2 fp=0x958679c sp=0x9586744 pc=0x8152662
testing.tRunner(0x95ae1e0, 0x820ebdc)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "testing" && test == "TestRacyOutput"
2022-11-16 14:42 linux-386-sid go@978ce7e2 testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0x820e970, 0x94203b0, 0xe, 0x17, 0x2)
	/workdir/go/src/runtime/proc.go:381 +0x108 fp=0x9586684 sp=0x9586670 pc=0x8081e38
runtime.chanrecv(0x9420380, 0x9586703, 0x1)
	/workdir/go/src/runtime/chan.go:583 +0x3f4 fp=0x95866cc sp=0x9586684 pc=0x804d964
runtime.chanrecv1(0x9420380, 0x9586703)
	/workdir/go/src/runtime/chan.go:442 +0x1c fp=0x95866e0 sp=0x95866cc pc=0x804d53c
testing.(*T).Run(0x95ae2d0, {0x0, 0x0}, 0x9600050)
	/workdir/go/src/testing/testing.go:1629 +0x446 fp=0x9586744 sp=0x95866e0 pc=0x8147bd6
testing.TestRacyOutput(0x95ae1e0)
	/workdir/go/src/testing/sub_test.go:814 +0x2c2 fp=0x958679c sp=0x9586744 pc=0x8152662
testing.tRunner(0x95ae1e0, 0x820ebdc)
2022-11-16 15:10 freebsd-386-13_0 go@70f585f0 testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0x8205164, 0x30e881b0, 0xe, 0x17, 0x2)
	/tmp/workdir/go/src/runtime/proc.go:381 +0xf6 fp=0x30d87e84 sp=0x30d87e70 pc=0x807feb6
runtime.chanrecv(0x30e88180, 0x30d87f03, 0x1)
	/tmp/workdir/go/src/runtime/chan.go:583 +0x3e8 fp=0x30d87ecc sp=0x30d87e84 pc=0x804d6d8
runtime.chanrecv1(0x30e88180, 0x30d87f03)
	/tmp/workdir/go/src/runtime/chan.go:442 +0x1c fp=0x30d87ee0 sp=0x30d87ecc pc=0x804d2bc
testing.(*T).Run(0x30d0a3c0, {0x0, 0x0}, 0x30c12060)
	/tmp/workdir/go/src/testing/testing.go:1629 +0x440 fp=0x30d87f44 sp=0x30d87ee0 pc=0x8140300
testing.TestRacyOutput(0x30d0a2d0)
	/tmp/workdir/go/src/testing/sub_test.go:814 +0x2bc fp=0x30d87f9c sp=0x30d87f44 pc=0x814ab9c
testing.tRunner(0x30d0a2d0, 0x82053d0)
2022-11-16 15:10 windows-amd64-longtest go@70f585f0 testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0xc000080000?, 0xc00030a020?, 0xa1?, 0x61?, 0xc00006bdc8?)
	C:/workdir/go/src/runtime/proc.go:381 +0xd6 fp=0xc00006bd48 sp=0xc00006bd28 pc=0x1cbed6
runtime.chanrecv(0xc0003b20e0, 0xc00006be47, 0x1)
	C:/workdir/go/src/runtime/chan.go:583 +0x49d fp=0xc00006bdd8 sp=0xc00006bd48 pc=0x196d9d
runtime.chanrecv1(0x4dbda0?, 0x33f8c0?)
	C:/workdir/go/src/runtime/chan.go:442 +0x18 fp=0xc00006be00 sp=0xc00006bdd8 pc=0x196898
testing.(*T).Run(0xc00013a680, {0x0?, 0x2a7f13?}, 0xc0003b40a0)
	C:/workdir/go/src/testing/testing.go:1629 +0x405 fp=0xc00006bec0 sp=0xc00006be00 pc=0x2a8ea5
testing.TestRacyOutput(0xc00013a4e0)
	C:/workdir/go/src/testing/sub_test.go:814 +0x2a6 fp=0xc00006bf70 sp=0xc00006bec0 pc=0x2b3686
testing.tRunner(0xc00013a4e0, 0x38ab30)
2022-11-16 16:25 darwin-amd64-12_0 go@38218f39 testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0x1322840?, 0xc00009e058?, 0xa1?, 0x41?, 0xc000345dc8?)
	/Users/gopher/workdir/go/src/runtime/proc.go:381 +0xd6 fp=0xc000345d48 sp=0xc000345d28 pc=0x1037d56
runtime.chanrecv(0xc0000de150, 0xc000345e47, 0x1)
	/Users/gopher/workdir/go/src/runtime/chan.go:583 +0x49d fp=0xc000345dd8 sp=0xc000345d48 pc=0x10065bd
runtime.chanrecv1(0x1321e60?, 0x11990e0?)
	/Users/gopher/workdir/go/src/runtime/chan.go:442 +0x18 fp=0xc000345e00 sp=0xc000345dd8 pc=0x10060b8
testing.(*T).Run(0xc0000831e0, {0x0?, 0x106bbc0?}, 0xc0000e00e0)
	/Users/gopher/workdir/go/src/testing/testing.go:1629 +0x405 fp=0xc000345ec0 sp=0xc000345e00 pc=0x11037e5
testing.TestRacyOutput(0xc000083040)
	/Users/gopher/workdir/go/src/testing/sub_test.go:814 +0x2a6 fp=0xc000345f70 sp=0xc000345ec0 pc=0x110de86
testing.tRunner(0xc000083040, 0x11e0698)
2022-11-16 16:25 linux-amd64-longtest-race go@38218f39 testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0xc000534c30?, 0x4441aa?, 0x40?, 0xd?, 0x0?)
	/workdir/go/src/runtime/proc.go:381 +0xd6 fp=0xc000534bb0 sp=0xc000534b90 pc=0x4701f6
runtime.chanrecv(0xc000212070, 0xc000534cae, 0x1)
	/workdir/go/src/runtime/chan.go:583 +0x42e fp=0xc000534c40 sp=0xc000534bb0 pc=0x43d22e
runtime.chanrecv1(0x852820?, 0x6827e0?)
	/workdir/go/src/runtime/chan.go:442 +0x18 fp=0xc000534c68 sp=0xc000534c40 pc=0x43cd98
testing.(*T).Run(0xc000481380, {0x0, 0x0}, 0xc000000070)
	/workdir/go/src/testing/testing.go:1629 +0x82e fp=0xc000534da8 sp=0xc000534c68 pc=0x59ae2e
testing.TestRacyOutput(0xc0004811e0)
	/workdir/go/src/testing/sub_test.go:814 +0x5be fp=0xc000534ea8 sp=0xc000534da8 pc=0x5abb7e
testing.tRunner(0xc0004811e0, 0x6d1158)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

Fixed in https://go.dev/cl/451215.

@bcmills bcmills closed this as completed Nov 17, 2022
@bcmills bcmills moved this to Done in Test Flakes Nov 17, 2022
@bcmills bcmills self-assigned this Nov 17, 2022
@bcmills bcmills added this to the Go1.20 milestone Nov 17, 2022
@gopherbot gopherbot reopened this Jan 4, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "testing" && test == "TestRacyOutput"
2022-11-16 16:42 darwin-amd64-12_0 go@0266671e testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0xc000370000?, 0xc000070020?, 0x71?, 0x2?, 0xc000103dc8?)
	/Users/gopher/workdir/go/src/runtime/proc.go:381 +0xd6 fp=0xc000103d48 sp=0xc000103d28 pc=0x1037d56
runtime.chanrecv(0xc00006a150, 0xc000103e47, 0x1)
	/Users/gopher/workdir/go/src/runtime/chan.go:583 +0x49d fp=0xc000103dd8 sp=0xc000103d48 pc=0x10065bd
runtime.chanrecv1(0x1321e60?, 0x11990e0?)
	/Users/gopher/workdir/go/src/runtime/chan.go:442 +0x18 fp=0xc000103e00 sp=0xc000103dd8 pc=0x10060b8
testing.(*T).Run(0xc00015a680, {0x0?, 0x106bbc0?}, 0xc00006c0e0)
	/Users/gopher/workdir/go/src/testing/testing.go:1629 +0x405 fp=0xc000103ec0 sp=0xc000103e00 pc=0x11037e5
testing.TestRacyOutput(0xc00015a4e0)
	/Users/gopher/workdir/go/src/testing/sub_test.go:814 +0x2a6 fp=0xc000103f70 sp=0xc000103ec0 pc=0x110de86
testing.tRunner(0xc00015a4e0, 0x11e0698)
2022-11-16 16:42 linux-arm-aws go@0266671e testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0x1f4c9c, 0xe34330, 0xe, 0x17, 0x2)
	/workdir/go/src/runtime/proc.go:381 +0x100 fp=0xc29e7c sp=0xc29e68 pc=0x4f260
runtime.chanrecv(0xe34300, 0xc29f03, 0x1)
	/workdir/go/src/runtime/chan.go:583 +0x538 fp=0xc29ec8 sp=0xc29e7c pc=0x15ed4
runtime.chanrecv1(0xe34300, 0xc29f03)
	/workdir/go/src/runtime/chan.go:442 +0x20 fp=0xc29edc sp=0xc29ec8 pc=0x1596c
testing.(*T).Run(0xe6c4b0, {0x0, 0x0}, 0xc0e1e8)
	/workdir/go/src/testing/testing.go:1629 +0x45c fp=0xc29f40 sp=0xc29edc pc=0x1255b8
testing.TestRacyOutput(0xe6c3c0)
	/workdir/go/src/testing/sub_test.go:814 +0x2d4 fp=0xc29f98 sp=0xc29f40 pc=0x130244
testing.tRunner(0xe6c3c0, 0x1f4f08)
2022-11-16 16:42 windows-386-2008 go@0266671e testing.TestRacyOutput (log) 
panic: testing: t.Run is called during t.Cleanup

runtime.gopark(0x5db8ac, 0xa8941b0, 0xe, 0x17, 0x2)
	C:/workdir/go/src/runtime/proc.go:381 +0xff fp=0xa97be84 sp=0xa97be70 pc=0x43ba4f
runtime.chanrecv(0xa894180, 0xa97bf03, 0x1)
	C:/workdir/go/src/runtime/chan.go:583 +0x3f4 fp=0xa97becc sp=0xa97be84 pc=0x405e34
runtime.chanrecv1(0xa894180, 0xa97bf03)
	C:/workdir/go/src/runtime/chan.go:442 +0x1c fp=0xa97bee0 sp=0xa97becc pc=0x405a0c
testing.(*T).Run(0xaaaa2d0, {0x0, 0x0}, 0xa896058)
	C:/workdir/go/src/testing/testing.go:1629 +0x446 fp=0xa97bf44 sp=0xa97bee0 pc=0x510986
testing.TestRacyOutput(0xaaaa1e0)
	C:/workdir/go/src/testing/sub_test.go:814 +0x2c2 fp=0xa97bf9c sp=0xa97bf44 pc=0x51b542
testing.tRunner(0xaaaa1e0, 0x5dbb48)

— watchflakes

@bcmills bcmills closed this as completed Jan 5, 2023
@golang golang locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Archived in project
Milestone
Go1.20
Development

No branches or pull requests
2 participants
@bcmills @gopherbot