Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add longtest builders for all first class ports #56822

Closed
FiloSottile opened this issue Nov 17, 2022 · 4 comments
Closed

x/build: add longtest builders for all first class ports #56822

FiloSottile opened this issue Nov 17, 2022 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@FiloSottile
Copy link
Contributor

We currently have no longtest builders for arm64 or arm. Although I know getting compute on non-amd64 architectures is harder, and longtests on arm might take forever, there's a lot of stuff that is skipped on -short. For example, ECDSA is only tested with one curve on -short. This does catch most mistakes, but it also fails to test a lot of architecture-specific code in other curve implementations. Ideally, a longtest builder would be a requirement for first class ports.

(Apologies if there's already an issue open for this, searching long tests didn't bring up anything.)

/cc @golang/release

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Nov 17, 2022
@bcmills
Copy link
Member

bcmills commented Nov 17, 2022

We currently have no longtest builders for arm64 or arm.

That's #49649.

(See also #35678 and #49055 for darwin/amd64 and darwin/arm64.)

@FiloSottile
Copy link
Contributor Author

Aha! Figured it'd be a duplicate. It's the original's birthday, too!
image

@FiloSottile
Copy link
Contributor Author

Feel free to close or keep it as an umbrella issue if it feels useful!

@joedian
Copy link

joedian commented Nov 18, 2022

Duplicate

@joedian joedian closed this as completed Nov 18, 2022
@golang golang locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

4 participants