Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/version_buildvcs_git_gpg (if enabled) fails on linux longtest builders [1.18 backport] #57054

Closed
gopherbot opened this issue Dec 2, 2022 · 2 comments
Closed

cmd/go: TestScript/version_buildvcs_git_gpg (if enabled) fails on linux longtest builders [1.18 backport] #57054

gopherbot opened this issue Dec 2, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18.10

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #57034 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.19 and 1.18: this test may fail spuriously due to problems with a fragile third-party tool.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 2, 2022
@gopherbot gopherbot mentioned this issue Dec 2, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.10 milestone Dec 2, 2022
@bcmills bcmills modified the milestones: Go1.18.10, Go1.18.9 Dec 2, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/454956 mentions this issue: [release-branch.go1.18] cmd/go: remove TestScript/version_buildvcs_git_gpg

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Dec 6, 2022
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Dec 7, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 7, 2022
gopherbot pushed a commit that referenced this issue Dec 9, 2022
@prattmic
[release-branch.go1.18] cmd/go: remove TestScript/version_buildvcs_gi…
2b98966 
…t_gpg

This was a regression test added for a 'git' command line
used for build stamping. Unfortunately, 'gpg' has proved to
be extremely fragile:

* In recent versions, it appears to always require 'gpg-agent' to be
  installed for anything involving secret keys, but for some reason is
  not normally marked as requiring gpg-agent in Debian's package
  manager.

* It tries to create a Unix domain socket in a subdirectory of $TMPDIR
  without checking the path length, which fails when $TMPDIR is too
  long to fit in the 'sun_path' field of a sockaddr_un struct (which
  typically tops out somewhere between 92 and 108 bytes).

We could theoretically address those by artificially reducing the
script's TMPDIR length and checking for gpg-agent in addition to gpg,
but arguably those should both be fixed upstream instead. On balance,
the incremental value that this test provides does not seem worth the
complexity of dealing with such a fragile third-party tool.

Updates #50675.
Updates #48802.
Updates #57034.
Fixes #57054.

Change-Id: Ia3288c2f84f8db86ddfa139b4d1c0112d67079ef
Reviewed-on: https://go-review.googlesource.com/c/go/+/454502
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 45f5ef4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454956
@gopherbot
Copy link
Contributor Author

Closed by merging 2b98966 to release-branch.go1.18.

@golang golang locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.18.10
Development

No branches or pull requests
4 participants
@prattmic @dmitshur @bcmills @gopherbot