Skip to content

cmd/dist: remove arch-specific timeout scale heuristics; handle these in x/build as needed #57117

Description

@dmitshur

Discussion in #56968 seems to suggest we have agreement to get cmd/dist out of the practice of maintaining a hardcoded timeout scale for a few architectures. Instead, dist users can set it for their own machine (if at all needed) and we can factor out this configuration into x/build/dashboard for builders.

That is, we should remove these lines from cmd/dist:

switch goarch {
case "arm":
	t.timeoutScale = 2
case "mips", "mipsle", "mips64", "mips64le":
	t.timeoutScale = 4
}

And adjust x/build as needed to avoid breaking any builders that might rely on that.

Breaking this off into this issue for tracking purposes.

CC @aclements, @bcmills.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions