Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestTerminalPassthrough failures due to missing output on darwin/amd64 #57141

Closed
bcmills opened this issue Dec 7, 2022 · 4 comments
Closed
Assignees
Labels
FrozenDueToAge GoCommand cmd/go OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Dec 7, 2022

#!watchflakes
post <- pkg == "cmd/go" && test == "TestTerminalPassthrough" && `expected exactly 2 bytes matching`

greplogs -e 'FAIL: TestTerminalPassthrough' --details

2022-12-02T23:40:37-c0497d1/darwin-amd64-12_0:

--- FAIL: TestTerminalPassthrough (0.67s)
    --- FAIL: TestTerminalPassthrough/pty (0.64s)
        terminal_test.go:74: running /tmp/buildlet/tmp/cmd-go-test-2093069953/tmpdir3970220742/testbin/go test -run=^$
        terminal_test.go:86: expected exactly 2 bytes matching [1X][2X]
        terminal_test.go:97: subprocess output:
FAIL
FAIL	cmd/go

2022-11-19T16:48:07-8a81fdf/darwin-amd64-aws-race:

--- FAIL: TestTerminalPassthrough (0.75s)
    --- FAIL: TestTerminalPassthrough/pty (0.70s)
        terminal_test.go:74: running /tmp/buildlet/tmp/cmd-go-test-3983325242/tmpdir2145448513/testbin/go test -run=^$
        terminal_test.go:86: expected exactly 2 bytes matching [1X][2X]
        terminal_test.go:97: subprocess output:
FAIL
FAIL	cmd/go

2022-11-18T21:02:24-7161fc7/darwin-amd64-nocgo-aws:

--- FAIL: TestTerminalPassthrough (0.68s)
    --- FAIL: TestTerminalPassthrough/pty (0.64s)
        terminal_test.go:74: running /tmp/buildlet/tmp/cmd-go-test-2385133147/tmpdir3640869849/testbin/go test -run=^$
        terminal_test.go:86: expected exactly 2 bytes matching [1X][2X]
        terminal_test.go:97: subprocess output:
FAIL
FAIL	cmd/go

2022-11-17T20:52:28-6e0e492/darwin-amd64-12-aws:

--- FAIL: TestTerminalPassthrough (0.69s)
    --- FAIL: TestTerminalPassthrough/pty (0.65s)
        terminal_test.go:74: running /tmp/buildlet/tmp/cmd-go-test-947321735/tmpdir3644870018/testbin/go test -run=^$
        terminal_test.go:86: expected exactly 2 bytes matching [1X][2X]
        terminal_test.go:97: subprocess output:
FAIL
FAIL	cmd/go

(4 matching logs)

@bcmills bcmills added this to the Go1.20 milestone Dec 7, 2022
@bcmills
Copy link
Member Author

bcmills commented Dec 7, 2022

This test was converted (and enabled on darwin) in CL 449503 (attn @aclements).

@bcmills bcmills self-assigned this Dec 7, 2022
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Dec 7, 2022
@gopherbot
Copy link

Change https://go.dev/cl/455915 mentions this issue: cmd/go: in TestTerminalPassthrough, delay subprocess exit until the PTY has been read

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestTerminalPassthrough" && `expected exactly 2 bytes matching`
2022-12-02 23:40 darwin-amd64-12_0 go@c0497d1a cmd/go.TestTerminalPassthrough (log)
vcs-test.golang.org rerouted to http://127.0.0.1:54952
https://vcs-test.golang.org rerouted to https://127.0.0.1:54953
go test proxy running at GOPROXY=http://127.0.0.1:54954/mod
--- FAIL: TestTerminalPassthrough (0.67s)
    --- FAIL: TestTerminalPassthrough/pty (0.64s)
        terminal_test.go:74: running /tmp/buildlet/tmp/cmd-go-test-2093069953/tmpdir3970220742/testbin/go test -run=^$
        terminal_test.go:86: expected exactly 2 bytes matching [1X][2X]
        terminal_test.go:97: subprocess output:

watchflakes

@gopherbot gopherbot reopened this Dec 17, 2022
@bcmills
Copy link
Member Author

bcmills commented Dec 17, 2022

2022-12-02 predates the fix CL.

@bcmills bcmills closed this as completed Dec 17, 2022
@golang golang locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge GoCommand cmd/go OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Status: Done
Development

No branches or pull requests

2 participants