-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: apparent deadlock in TestDebugCallUnsafePoint #57311
Comments
We already know this code plays it fast and loose a bit. There's a requirement that the test code here doesn't have any write barriers, and yet we know that it does. But since this is stalling when trying to set GOMAXPROCS, i.e. when it's trying to STW and preempt everything, we might be leaving behind some bad state. I'll take a look. |
Also, this is almost certainly a test-only bug. Those issues are with the test code, not the typical use of this feature. (This feature is also only used when debugging, and even then somewhat rarely, so it's not on a critical path.) Not a release blocker, IMO. |
One more interesting goroutine from that trace:
|
This looks like the |
Found new dashboard test flakes for:
2023-02-04 07:02 android-amd64-emu go@864b54e2 runtime.TestDebugCallPanic (log)
|
Found new dashboard test flakes for:
2023-05-23 11:36 linux-amd64-boringcrypto go@0cd04724 runtime (log)
|
Sorry for the delay here, still planning to look into it. |
Found new dashboard test flakes for:
2023-05-25 00:49 linux-amd64 go@558301a5 runtime.TestDebugCallUnsafePoint (log)
|
https://storage.googleapis.com/go-build-log/e9552219/linux-amd64-nounified_87ac7ca9.log (a TryBot on https://go.dev/cl/457336):
The text was updated successfully, but these errors were encountered: