Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: the mips64 intrinsic for CompareAndSwapUint32 function needs to sign extend its "old" argument #57332

Closed
dr2chase opened this issue Dec 15, 2022 · 4 comments
Labels
arch-mips compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@dr2chase
Copy link
Contributor

This is the mips64 version of #57282, separately created for backport workflow.
(The bug is that if LL/SC is used to implement CAS, the sign extension of the "old" value must match the sign extension for store/conditional).

The fix is in https://go.dev/cl/457535

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 15, 2022
@dr2chase dr2chase added this to the Go1.20 milestone Dec 15, 2022
@dr2chase dr2chase added NeedsFix The path to resolution is known, but the work has not been done. release-blocker compiler/runtime Issues related to the Go compiler and/or runtime. and removed compiler/runtime Issues related to the Go compiler and/or runtime. labels Dec 15, 2022
@dr2chase
Copy link
Contributor Author

Marked as release-blocker for workflow purposes; this is a minor port, but we have time, and failures in synchronization operations are horrible and the fix is safe and narrowly targeted.

@dr2chase
Copy link
Contributor Author

@gopherbot please open backport issues.

@gopherbot
Copy link
Contributor

Backport issue(s) opened: #57340 (for 1.18), #57341 (for 1.19).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@dr2chase
Copy link
Contributor Author

Closed because three bugs and CLs were merged into one.

@golang golang locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-mips compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants