Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestTransportIdleCacheKeys failures with missing cache keys #57375

Open
gopherbot opened this issue Dec 17, 2022 · 15 comments
Open

net/http: TestTransportIdleCacheKeys failures with missing cache keys #57375

gopherbot opened this issue Dec 17, 2022 · 15 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Dec 17, 2022

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys" && `After Get expected 1 idle conn cache keys; got 0`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.27s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2022-12-14 19:13 darwin-amd64-10_15 go@5c682f94 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.27s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2022-12-21 18:56 darwin-amd64-nocgo go@458241f9 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.06s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2022-12-02 16:29 freebsd-arm-paulzhol go@1711f953 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.33s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2023-01-09 20:25 freebsd-arm-paulzhol go@0bbd67e5 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.10s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0
2023-01-11 22:29 freebsd-arm-paulzhol go@245e95df net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.38s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2023-01-03 17:21 darwin-amd64-11_0 go@eb598248 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.07s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0
2023-01-25 21:16 darwin-amd64-13 go@4f467f10 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.08s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0
2023-01-28 19:00 freebsd-arm-paulzhol go@915af1b7 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.63s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2023-02-09 17:01 darwin-amd64-13 go@8ffcd3da net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.06s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2023-02-02 23:39 darwin-amd64-12_0 go@3313880b net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.06s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0
2023-02-10 17:41 freebsd-arm-paulzhol go@7628627c net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.46s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0
2023-02-10 21:45 darwin-amd64-race go@f0cb44a7 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.07s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys"
2023-03-10 17:59 freebsd-arm-paulzhol go@9872428a net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (1.23s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@bcmills bcmills changed the title net/http: TestTransportIdleCacheKeys failures net/http: TestTransportIdleCacheKeys failures with missing cache keys Mar 14, 2023
@bcmills bcmills added this to the Backlog milestone Mar 14, 2023
@bcmills
Copy link
Member

bcmills commented Mar 14, 2023

This is another one in the darwin + freebsd cluster (attn @neild @paulzhol)

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys" && `After Get expected 1 idle conn cache keys; got 0`
2023-03-14 16:42 darwin-amd64-11_0 go@46bc9a6e net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.06s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys" && `After Get expected 1 idle conn cache keys; got 0`
2023-04-06 20:58 darwin-amd64-11_0 go@57b4df21 net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.08s)
        transport_test.go:413: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/483116 mentions this issue: net/http: wait forever for write results in tests

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys" && `After Get expected 1 idle conn cache keys; got 0`
2023-04-14 17:58 darwin-amd64-nocgo go@ecf7e00d net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.09s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot gopherbot reopened this Apr 24, 2023
@bcmills
Copy link
Member

bcmills commented Apr 24, 2023

ecf7e00d is on release-branch.go1.20 (see #59483).

@neild, do you think the fix CL is worth backporting to reduce noise during releases?

@bcmills bcmills closed this as completed Apr 24, 2023
@dmitshur dmitshur modified the milestones: Backlog, Go1.21 May 24, 2023
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 24, 2023
@gopherbot gopherbot reopened this Jul 3, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportIdleCacheKeys" && `After Get expected 1 idle conn cache keys; got 0`
2023-06-22 15:41 freebsd-arm-paulzhol go@b8e67d1d net/http.TestTransportIdleCacheKeys (log)
--- FAIL: TestTransportIdleCacheKeys (0.00s)
    --- FAIL: TestTransportIdleCacheKeys/h1 (0.23s)
        transport_test.go:411: After Get expected 1 idle conn cache keys; got 0

watchflakes

@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@gopherbot gopherbot modified the milestones: Go1.22, Go1.23 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Status: Done
Development

No branches or pull requests

3 participants