Skip to content

x/website: broken links on blog/why-generics #57421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glycerine opened this issue Dec 21, 2022 · 3 comments
Closed

x/website: broken links on blog/why-generics #57421

glycerine opened this issue Dec 21, 2022 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@glycerine
Copy link

https://go.dev/blog/why-generics

says

Note added January 2022: This blog post was written in 2019 and 
does not describe the version of generics that was finally adopted. 
For updated information please see [the language spec](https://go.dev/ref/spec) and
 [the generics design document] (https://go.dev/design/43651-type-parameters).

The design document link is broken, giving the following error

NOT_FOUND: Requested entity was not found

You may not have access to this page. You can retry after signing in.
[Sign in](https://accounts.google.com/AccountChooser?service=gerritcodereview&continue=https://go.googlesource.com/login/proposal/%2B/master/design/43651-type-parameters%29.md)

[type.googleapis.com/google.rpc.LocalizedMessage]
locale: "en-US"
message: "Object is not found"

[type.googleapis.com/google.rpc.RequestInfo]
request_id: "133005606361471fa2e31ecb656293dc"

The language spec link is not helpful regarding generics. It has only one instance of the word generics, and this does not describe the implementation at all, only to point to old docs of the pre-generics Go:

"This is the reference manual for the Go programming language. The pre-Go1.18 version, without generics, can be found here."

These links should be updated to point to useful information about the present form of the generics implementation.

@fzipp
Copy link
Contributor

fzipp commented Dec 21, 2022

The URL itself is correct, but the markdown contains a misplaced space between description and URL, which breaks the rendering of the link.

The language spec link is not helpful regarding generics. It has only one instance of the word generics

The feature is called "type parameters" in the spec.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/458795 mentions this issue: _content/blog: fix broken link to design document in why-generics

@dr2chase dr2chase added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 21, 2022
@dr2chase
Copy link
Contributor

The CL looks plausible to me, I pinged @ianlancetaylor as a reviewer.

@seankhliao seankhliao changed the title dangling and unhelpful links in generics blog post https://go.dev/blog/why-generics x/website: broken links on blog/why-generics Dec 22, 2022
@golang golang locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants