-
Notifications
You must be signed in to change notification settings - Fork 18k
x/net/http2: TestTransportReturnsUnusedFlowControlMultipleWrites failures #57578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Found new dashboard test flakes for:
2023-01-04 15:52 linux-ppc64le-buildlet net@8e0e7d8d go@c1760296 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
This looks like a deadlock, and I would be surprised if it did not also affect at least other (atten @neild) |
Found new dashboard test flakes for:
2023-01-04 15:52 linux-ppc64le-buildlet net@8e0e7d8d go@9955a7e9 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-04 15:52 linux-amd64-longtest-race net@8e0e7d8d go@4e7c8384 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 netbsd-arm64-bsiegert net@f8411da7 go@d50ea217 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 linux-amd64-nocgo net@f8411da7 go@119f679a x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Indeed, there it is — |
Looks like this hasn't been pulled into the main repo yet, so this doesn't need to be a release blocker for 1.20 unless we're planning to refresh the But it will presumably need to be resolved before we can update |
We create internal vendor branches for x repos at the time of cutting RC 1 (see #11811 (comment)), and after that point we've generally been adding to that branch only the CLs that are necessary to fix release-blocking issues for the given release. So the 1.21 milestone seems okay to start out with here. |
Found new dashboard test flakes for:
2023-01-05 16:42 android-amd64-emu net@f8411da7 go@841c3eb1 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
2023-01-05 16:42 android-amd64-emu net@f8411da7 go@f721fa3b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 linux-ppc64le-buildlet net@f8411da7 go@841c3eb1 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 netbsd-amd64-9_3 net@f8411da7 go@8232a09e x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 android-amd64-emu net@f8411da7 go@0bbd67e5 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 linux-386-bullseye net@f8411da7 go@0202ad0b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
2023-01-05 16:42 netbsd-386-9_3 net@f8411da7 go@0202ad0b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 netbsd-amd64-9_3 net@f8411da7 go@8409251e x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 linux-loong64-3a5000 net@f8411da7 go@c0799f70 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 linux-ppc64le-buildlet net@f8411da7 go@d45df066 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 android-386-emu net@f8411da7 go@73e1affe x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 netbsd-amd64-9_3 net@f8411da7 go@8d71ae8c x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-01-05 16:42 android-386-emu net@f8411da7 go@8d71ae8c x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-02-28 08:42 linux-386-longtest net@1d46ed8b go@0487ba08 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-02-28 08:42 netbsd-arm64-bsiegert net@1d46ed8b go@6f4d986a x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-02-28 08:42 linux-amd64-boringcrypto net@1d46ed8b go@0d288f90 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-02-28 08:42 linux-amd64-race net@1d46ed8b go@5e74bc1a x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-03 16:07 linux-ppc64-sid-buildlet net@8c4ef2f8 go@cd6d225b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-03 16:07 linux-amd64-longtest-race net@8c4ef2f8 go@ce2a6099 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-03 16:07 linux-amd64-goamd64v3 net@8c4ef2f8 go@b94dc384 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 android-amd64-emu net@dfa2b5df go@74502e9b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 android-386-emu net@dfa2b5df go@34d6aaae x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 linux-ppc64-sid-buildlet net@dfa2b5df go@74502e9b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 linux-amd64-race net@dfa2b5df go@8f92ae1c x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 linux-ppc64le-buildlet net@dfa2b5df go@c6cdfdab x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 linux-386-clang net@dfa2b5df go@84609d87 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 android-386-emu net@dfa2b5df go@7bd22aaf x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
2023-03-05 02:51 netbsd-386-9_3 net@dfa2b5df go@7bd22aaf x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-07 22:09 linux-amd64-buster net@08dda575 go@7bd22aaf x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-05 02:51 linux-mips64-rtrk net@dfa2b5df go@84609d87 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-07 22:09 linux-ppc64-sid-buildlet net@08dda575 go@457fd1d5 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-02-14 17:04 darwin-amd64-11_0 net@8e2b117a go@4a1829b6 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
2023-02-14 17:04 linux-mips64-rtrk net@8e2b117a go@f98dd299 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-07 22:09 linux-ppc64le-buildlet net@08dda575 go@20c96a7d x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Change https://go.dev/cl/475135 mentions this issue: |
This is a real bug. The problem is that when the user closes a There is, therefore, a race condition between closing a request/response body and notifying the peer that it can stop sending data. For the Transport case, this manifests as a flaky test. The Server case wasn't covered by any tests. See https://go.dev/cl/475135 for more details and fix. |
Found new dashboard test flakes for:
2023-03-07 22:09 linux-amd64-longtest net@08dda575 go@7042ea62 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Found new dashboard test flakes for:
2023-03-07 22:09 darwin-amd64-12_0 net@08dda575 go@4460291e x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
|
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: