Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestStackGrowth failures #57601

Closed
gopherbot opened this issue Jan 4, 2023 · 6 comments
Closed

runtime: TestStackGrowth failures #57601

gopherbot opened this issue Jan 4, 2023 · 6 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Jan 4, 2023

#!watchflakes
post <- pkg == "runtime" && `panic: finalizer started .* ago .* and ran \d+ iterations, but did not return`

Issue created automatically to collect these failures.

Example (log):

panic: finalizer started 104.093721ms ago (1.068654ms after registration) and ran 98 iterations, but did not return

runtime.gopark(0x843adec, 0x86a8a00, 0x12, 0x19, 0x4)
	/tmp/workdir/go/src/runtime/proc.go:381 +0xf6 fp=0x5884fe4c sp=0x5884fe38 pc=0x8089086
runtime.goparkunlock(...)
	/tmp/workdir/go/src/runtime/proc.go:387
runtime.semacquire1(0x58b94438, 0x0, 0x1, 0x0, 0x12)
	/tmp/workdir/go/src/runtime/sema.go:160 +0x239 fp=0x5884fe80 sp=0x5884fe4c pc=0x809a709
sync.runtime_Semacquire(0x58b94438)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x35 fp=0x5884fe98 sp=0x5884fe80 pc=0x80bdec5
sync.(*WaitGroup).Wait(0x58b94430)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x5f fp=0x5884feb4 sp=0x5884fe98 pc=0x80c795f
runtime_test.TestStackGrowth(0x58d82000)
	/tmp/workdir/go/src/runtime/stack_test.go:141 +0x55a fp=0x5884ff9c sp=0x5884feb4 pc=0x836e89a
testing.tRunner(0x58d82000, 0x843bb54)

watchflakes

@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestStackGrowth"
2022-11-29 01:18 openbsd-386-71 go@0fd7be7e runtime.TestStackGrowth (log)
panic: finalizer started 104.093721ms ago (1.068654ms after registration) and ran 98 iterations, but did not return

runtime.gopark(0x843adec, 0x86a8a00, 0x12, 0x19, 0x4)
	/tmp/workdir/go/src/runtime/proc.go:381 +0xf6 fp=0x5884fe4c sp=0x5884fe38 pc=0x8089086
runtime.goparkunlock(...)
	/tmp/workdir/go/src/runtime/proc.go:387
runtime.semacquire1(0x58b94438, 0x0, 0x1, 0x0, 0x12)
	/tmp/workdir/go/src/runtime/sema.go:160 +0x239 fp=0x5884fe80 sp=0x5884fe4c pc=0x809a709
sync.runtime_Semacquire(0x58b94438)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x35 fp=0x5884fe98 sp=0x5884fe80 pc=0x80bdec5
sync.(*WaitGroup).Wait(0x58b94430)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x5f fp=0x5884feb4 sp=0x5884fe98 pc=0x80c795f
runtime_test.TestStackGrowth(0x58d82000)
	/tmp/workdir/go/src/runtime/stack_test.go:141 +0x55a fp=0x5884ff9c sp=0x5884feb4 pc=0x836e89a
testing.tRunner(0x58d82000, 0x843bb54)
2022-12-14 19:13 openbsd-386-71 go@5c682f94 runtime.TestStackGrowth (log)
panic: finalizer started 152.908275ms ago (1.393595ms after registration) and ran 153 iterations, but did not return

runtime.gopark(0x843a718, 0x86a8180, 0x12, 0x19, 0x4)
	/tmp/workdir/go/src/runtime/proc.go:381 +0xf6 fp=0x5a04ee4c sp=0x5a04ee38 pc=0x8089086
runtime.goparkunlock(...)
	/tmp/workdir/go/src/runtime/proc.go:387
runtime.semacquire1(0x5a5613f8, 0x0, 0x1, 0x0, 0x12)
	/tmp/workdir/go/src/runtime/sema.go:160 +0x239 fp=0x5a04ee80 sp=0x5a04ee4c pc=0x809a6f9
sync.runtime_Semacquire(0x5a5613f8)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x35 fp=0x5a04ee98 sp=0x5a04ee80 pc=0x80bdeb5
sync.(*WaitGroup).Wait(0x5a5613f0)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x5f fp=0x5a04eeb4 sp=0x5a04ee98 pc=0x80c794f
runtime_test.TestStackGrowth(0x5a1a3770)
	/tmp/workdir/go/src/runtime/stack_test.go:141 +0x55a fp=0x5a04ef9c sp=0x5a04eeb4 pc=0x836e32a
testing.tRunner(0x5a1a3770, 0x843b484)

watchflakes

@bcmills

This comment was marked as outdated.

@bcmills bcmills marked this as a duplicate of #57585 Jan 6, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
@bcmills bcmills reopened this Jan 6, 2023
@bcmills
Copy link
Member

bcmills commented Jan 6, 2023

https://build.golang.org/log/5571acfcf4d4d6de5d3f22b56f8c2dca2623f7cc (netbsd-arm64-bsiegert) also has one of these, so it's not just openbsd-.*-71.

@bcmills bcmills marked this as not a duplicate of #57585 Jan 6, 2023
@bcmills
Copy link
Member

bcmills commented Jan 6, 2023

Hmm, but that's also a test timeout, not specific to this test (which only ran, in parallel, for 14s). 🤔

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && `panic: finalizer started .* ago .* and ran \d+ iterations, but did not return`
2023-01-09 18:21 openbsd-386-71 go@8232a09e runtime.TestStackGrowth (log)
panic: finalizer started 181.140689ms ago (1.280705ms after registration) and ran 191 iterations, but did not return

runtime.gopark(0x843a6f0, 0x86a7c40, 0x12, 0x19, 0x4)
	/tmp/workdir/go/src/runtime/proc.go:381 +0xf6 fp=0x5944de4c sp=0x5944de38 pc=0x8089086
runtime.goparkunlock(...)
	/tmp/workdir/go/src/runtime/proc.go:387
runtime.semacquire1(0x596ce088, 0x0, 0x1, 0x0, 0x12)
	/tmp/workdir/go/src/runtime/sema.go:160 +0x239 fp=0x5944de80 sp=0x5944de4c pc=0x809a6f9
sync.runtime_Semacquire(0x596ce088)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x35 fp=0x5944de98 sp=0x5944de80 pc=0x80bdeb5
sync.(*WaitGroup).Wait(0x596ce080)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x5f fp=0x5944deb4 sp=0x5944de98 pc=0x80c794f
runtime_test.TestStackGrowth(0x595bf950)
	/tmp/workdir/go/src/runtime/stack_test.go:141 +0x55a fp=0x5944df9c sp=0x5944deb4 pc=0x836e54a
testing.tRunner(0x595bf950, 0x843b45c)

watchflakes

@gopherbot gopherbot reopened this Jan 16, 2023
@bcmills
Copy link
Member

bcmills commented Jan 17, 2023

#57585

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Done
Development

No branches or pull requests

2 participants