-
Notifications
You must be signed in to change notification settings - Fork 18k
net/http: TestServerCancelsReadTimeoutWhenIdle failures #57602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Found new dashboard test flakes for:
2022-11-30 17:03 netbsd-arm-bsiegert go@60525dc3 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
2s is the longest of the (still arbitrary) timeouts in this list: But the test is only setting (CC @neild) |
Found new dashboard test flakes for:
2023-01-30 08:01 freebsd-arm-paulzhol go@932d0ae8 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
2023-01-31 13:55 freebsd-arm-paulzhol go@da0c375c net/http.TestServerCancelsReadTimeoutWhenIdle (log)
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Found new dashboard test flakes for:
2023-02-07 23:39 freebsd-arm-paulzhol go@0b9974d3 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Found new dashboard test flakes for:
2023-02-17 00:06 freebsd-arm-paulzhol go@031401a7 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Found new dashboard test flakes for:
2023-03-07 18:26 freebsd-arm-paulzhol go@74a9d283 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Found new dashboard test flakes for:
2023-09-15 23:22 freebsd-arm-paulzhol go@561a5079 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Change https://go.dev/cl/529755 mentions this issue: |
In case of a handshake timeout, the goroutine running addTLS closes the underlying connection, which should unblock the call to tlsConn.HandshakeContext. However, it didn't then wait for HandshakeContext to actually return. I thought this might have something to do with #57602, but as far as I can tell it does not. Still, it seems best to avoid the leak: if tracing is enabled we emit a TLSHandshakeDone event, and it seems misleading to produce that event when the handshake is still in progress. For #57602. Change-Id: Ibfc0cf4ef8df2ccf11d8897f23d7d79ee482d5fb Reviewed-on: https://go-review.googlesource.com/c/go/+/529755 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> Commit-Queue: Bryan Mills <bcmills@google.com>
Found new dashboard test flakes for:
2023-12-08 20:36 freebsd-arm-paulzhol go@b55bf2d7 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Found new dashboard test flakes for:
2023-12-11 22:29 freebsd-arm-paulzhol go@a839ec1e net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Found new dashboard test flakes for:
2024-01-12 16:19 freebsd-arm-paulzhol go@e58e8139 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Found new dashboard test flakes for:
2024-02-10 02:03 freebsd-arm-paulzhol go@a1878904 net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
@paulzhol, there are a lot of these on the |
The last 3 appear to be almost a month apart from each other on a Friday/Saturday, which is the weekend for me here. |
Found new dashboard test flakes for:
2024-03-26 21:33 freebsd-arm-paulzhol go@b47f2feb net/http.TestServerCancelsReadTimeoutWhenIdle (log)
|
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: