Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: revisit line directive support #57640

Open
findleyr opened this issue Jan 5, 2023 · 0 comments
Open

x/tools/gopls: revisit line directive support #57640

findleyr opened this issue Jan 5, 2023 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Jan 5, 2023

Following our removal of line directive support from the core of gopls, we should re-evaluate whether or not there are selected areas where we can / should expand positions to related positions (e.g. duplicating or re-mapping diagnostics, handling jump-to-definition requests, etc.).

@findleyr findleyr added this to the gopls/v0.12.0 milestone Jan 5, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 5, 2023
@adonovan adonovan added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants