Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: fix duplicate module path detection with go.work #57650

Open
findleyr opened this issue Jan 6, 2023 · 0 comments
Open

x/tools/gopls: fix duplicate module path detection with go.work #57650

findleyr opened this issue Jan 6, 2023 · 0 comments
Assignees
Labels
gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Jan 6, 2023

Reminder issue: following the experimentalWorkspaceModule removal, our detection of duplicate module paths in go.work is broken (see TestBrokenWorkspace_DuplicateModules).

This should be fixed before the next release.

@findleyr findleyr added the gopls/workspace Issues related to support for modules or multi-module workspaces. label Jan 6, 2023
@findleyr findleyr added this to the gopls/v0.12.0 milestone Jan 6, 2023
@findleyr findleyr self-assigned this Jan 6, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants