Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/rsa: port Validate to bigmod #57751

Open
Tracked by #57752
FiloSottile opened this issue Jan 12, 2023 · 2 comments
Open
Tracked by #57752

crypto/rsa: port Validate to bigmod #57751

FiloSottile opened this issue Jan 12, 2023 · 2 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@FiloSottile
Copy link
Contributor

FiloSottile commented Jan 12, 2023 •
edited
Loading

PrivateKey.Validate still uses math/big. That's mostly fine, but if we port it to bigmod and invoke it at the end of GenerateKey and Precompute, we can backstop the correctness of math/big with the more easily verified correctness of bigmod.
@FiloSottile FiloSottile changed the title crypto/rsa: crypto/rsa: port Validate to bigmod Jan 12, 2023
@FiloSottile FiloSottile self-assigned this Jan 12, 2023
@FiloSottile FiloSottile added this to the Go1.21 milestone Jan 12, 2023
@FiloSottile FiloSottile mentioned this issue Jan 12, 2023
Open
12 tasks
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 20, 2023
@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@odeke-em
Copy link
Member

Moving this to Go1.23

@odeke-em odeke-em modified the milestones: Go1.22, Go1.23 Dec 16, 2023
@gopherbot gopherbot modified the milestones: Go1.23, Go1.24 Aug 13, 2024
@FiloSottile
Copy link
Contributor Author

This is necessary for #69536.

@FiloSottile FiloSottile removed their assignment Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
4 participants
@FiloSottile @odeke-em @gopherbot @seankhliao