Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: remove the experimentalPackageCacheKey setting #57853

Closed
findleyr opened this issue Jan 17, 2023 · 1 comment
Closed

x/tools/gopls: remove the experimentalPackageCacheKey setting #57853

findleyr opened this issue Jan 17, 2023 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

This setting need not exist. We should have but one cache key, and it should be correct.

(this setting has also been enabled by default for a long time, though I don't think our cache key is actually correct; fix incoming)
@findleyr findleyr added this to the gopls/v0.12.0 milestone Jan 17, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 17, 2023
@gopherbot
Copy link

Change https://go.dev/cl/461944 mentions this issue: gopls/internal/lsp/cache: remove package dependence on packages.Config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr