Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestCloseWithBlockingReadByFd failures #57994

Closed
gopherbot opened this issue Jan 25, 2023 · 2 comments
Closed

os: TestCloseWithBlockingReadByFd failures #57994

gopherbot opened this issue Jan 25, 2023 · 2 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "os" && test == "TestCloseWithBlockingReadByFd"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCloseWithBlockingReadByFd (1.02s)
    pipe_test.go:351: timed out waiting for Read and Close

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 25, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "os" && test == "TestCloseWithBlockingReadByFd"
2023-01-19 22:21 dragonfly-amd64-622 go@aa51c40b os.TestCloseWithBlockingReadByFd (log) 
--- FAIL: TestCloseWithBlockingReadByFd (1.02s)
    pipe_test.go:351: timed out waiting for Read and Close

— watchflakes

@bcmills bcmills self-assigned this Jan 25, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 25, 2023
@bcmills bcmills added this to the Go1.21 milestone Jan 25, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 25, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/463180 mentions this issue: os: eliminate arbitrary timeout in testClosewithBlockingRead

@golang golang locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot