Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: ssacheck builder broken by go.dev/cl/458625 #58104

Closed
mdempsky opened this issue Jan 26, 2023 · 1 comment
Closed

x/build: ssacheck builder broken by go.dev/cl/458625 #58104

mdempsky opened this issue Jan 26, 2023 · 1 comment
Assignees
@mdempsky
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Unreleased

Comments

@mdempsky
Copy link
Contributor

mdempsky commented Jan 26, 2023 •
edited
Loading

go.dev/cl/458625 removed the -d=dclstack flag from the compiler, but apparently it's being used by the ssacheck builder: https://build.golang.org/log/99792b3a11bf499064ac5417106e27eaf7ee0fa9

The flag is a noop now anyway, so it should be safe to just drop it wherever we're setting it. If that's going to be difficult in the short term, we can restore the flag temporarily to appease the builders.
@mdempsky mdempsky added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Jan 26, 2023
@mdempsky mdempsky self-assigned this Jan 26, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 26, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/463775 mentions this issue: dashboard: remove -d=dclstack compiler flag for ssacheck builder

@dmitshur dmitshur moved this to In Progress in Go Release Jan 26, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jan 26, 2023
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 26, 2023
@cherrymui cherrymui mentioned this issue Feb 2, 2023
Closed
@golang golang locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdempsky mdempsky

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mdempsky @dmitshur @gopherbot