Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv4: multicast ICMP tests fail when net.inet.icmp.bmcastecho=0 #5811

Closed
mikioh opened this issue Jun 29, 2013 · 14 comments
Closed

x/net/ipv4: multicast ICMP tests fail when net.inet.icmp.bmcastecho=0 #5811

mikioh opened this issue Jun 29, 2013 · 14 comments

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Jun 29, 2013

--- FAIL: TestReadWriteMulticastIPPayloadICMP-2 (0.00 seconds)
    mocktransponder_test.go:42: rcvd cmsg: ttl: 1, src: 127.0.0.1, dst: 224.0.0.254, ifindex: 7
    multicast_test.go:106: got type=echo, code=0; expected type=echo reply, code=0
--- FAIL: TestReadWriteMulticastIPDatagram-2 (0.00 seconds)
    mocktransponder_test.go:73: rcvd cmsg: ttl: 1, src: 127.0.0.1, dst: 224.0.0.254, ifindex: 7
    mocktransponder_test.go:74: rcvd hdr: ver: 4, hdrlen: 20, tos: 0x1, totallen: 43, id: 0x5b5a, fragoff: 0x0, ttl: 1, proto: 1, cksum: 0xfe77, src: 127.0.0.1, dst: 224.0.0.254
    multicast_test.go:165: got type=echo, code=0; expected type=echo reply, code=0
FAIL
@davecheney
Copy link
Contributor

@davecheney davecheney commented Jun 29, 2013

Comment 1:

Which host/os, etc ?

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Jun 29, 2013

Comment 2:

FreeBSD 9.x.
Just indicates loopback'd sent packets but got no replies from protocol stack inside the
kernel.
Hm, loopback marker's bug maybe.

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Jul 1, 2013

Comment 3:

Nope, I completely forgot that old RFC says "An ICMP Echo Request destined to an IP
broadcast or IP multicast address MAY be silently discarded" and almost all
implementations follow that direction. Will fix the test case.

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Jul 1, 2013

Comment 4:

Of course, net.inet.icmp.bmcastech=0 by default on BSD bros.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2013

Comment 5 by atkaaz:

I have only one related fail but on Windows 7 64bit, possibly because I've disabled some
things in this system (but can't remember what and where but ie. maybe multicast is
disabled, but it's not because the firewall is silently blocking it(without logging)
because I've disabled the firewall and still happens)
ok      mime/multipart  0.863s
--- FAIL: TestIPv4MulticastListener (0.02 seconds)
        multicast_test.go:53: First ListenMulticastUDP on <nil> failed: listen udp 224.0.0.254: set
sockopt: An unknown, invalid, or unsupported option or level was specified in a
getsockopt or setso
ckopt call.
FAIL
FAIL    net     3.160s
ok      net/http        5.568s
this was the go version used in the test:
http://code.google.com/p/go/source/detail?r=749d021640436ab33eb8dfdb25bbec472e80af73
go version devel +749d02164043 Thu Aug 15 14:38:32 2013 -0400 windows/amd64

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Aug 15, 2013

Comment 6:

Sorry, but that's net package's fault. Please open new issue because we focus on the
issue of code.google.com/p/.go.net/ipv4 package here.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2013

Comment 7 by atkaaz:

Ok sorry, I thought since it's the same multicast_test.go file(but different line), this
would be the place. I'll open a new issue, thanks.

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Nov 3, 2013

Comment 8:

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @mikioh.

@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 9:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 10:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 11:

Labels changed: added repo-net.

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Dec 5, 2013

Comment 12:

https://golang.org/cl/21360043/

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 9, 2014

Comment 13:

CL https://golang.org/cl/21360043 references this issue.

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Apr 27, 2014

Comment 14:

This issue was closed by revision golang/net@8ecd624.

Status changed to Fixed.

@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh mikioh changed the title go.net/ipv4: multicast ICMP tests fail when net.inet.icmp.bmcastecho=0 ipv4: multicast ICMP tests fail when net.inet.icmp.bmcastecho=0 Jan 4, 2015
@mikioh mikioh changed the title ipv4: multicast ICMP tests fail when net.inet.icmp.bmcastecho=0 x/net/ipv4: multicast ICMP tests fail when net.inet.icmp.bmcastecho=0 Jul 20, 2015
@golang golang locked and limited conversation to collaborators Jul 20, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants