Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build,cmd/link: darwin/amd64 builders unexpectedly skipping cmd/link.TestBuildForTvOS #58231

Open
bcmills opened this issue Feb 1, 2023 · 7 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) compiler/runtime Issues related to the Go compiler and/or runtime. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Feb 1, 2023

In #58221 we observed consistent test failures in cmd/link.TestBuildForTvOS on darwin-amd64-11_0, but not on the other darwin/amd64 builders. The root cause of the failure is not OS-dependent, which suggests that the test is being skipped on all of the other darwin/amd64 builders. That is unexpected.

We should probably:

  • adjust those builders so that they can run the test (attn @golang/release), and
  • adjust the test so that it fails instead of skipping if GO_BUILDER_NAME is non-empty (attn @golang/compiler, @golang/ios).

(The discussion on #58221 covers more detail about the skips.)

@gopherbot gopherbot added Builders x/build issues (builders, bots, dashboards) compiler/runtime Issues related to the Go compiler and/or runtime. labels Feb 1, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 1, 2023
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed compiler/runtime Issues related to the Go compiler and/or runtime. labels Feb 1, 2023
@bcmills bcmills modified the milestones: Unreleased, Backlog Feb 1, 2023
@bcmills bcmills added compiler/runtime Issues related to the Go compiler and/or runtime. mobile Android, iOS, and x/mobile labels Feb 1, 2023
@cherrymui
Copy link
Member

Yeah, the test requires tvOS SDK installed on the machine. Not sure they are...

@heschi
Copy link
Contributor

heschi commented Feb 7, 2023

cc @prattmic for the next time we build macOS images?

@heschi
Copy link
Contributor

heschi commented Feb 7, 2023

@golang/ios How much do we care about this test?

@changkun
Copy link
Member

changkun commented Feb 7, 2023

cc @eliasnaur

@prattmic
Copy link
Member

prattmic commented Feb 7, 2023

The different builders have slightly different versions of XCode installed (generally the latest that happens to be supported by that OS version). It wouldn't surprise me if one of those XCode installations isn't quite right. Exact installation steps seemed to vary slightly from version to version, so it wouldn't surprise me if something went wrong along the way.

@dmitshur
Copy link
Contributor

dmitshur commented Feb 8, 2023

Xcode completes its installation on its first launch, showing a prompt that looks like this (in a recent version):

image

So it'd be a matter of not forgetting to check the box next to tvOS and pressing continue next time.

@prattmic
Copy link
Member

prattmic commented Feb 8, 2023

I may have done the installation incorrectly, but FWIW I never saw that window on any of the Xcode installations I did for Darwin builders. IIRC, the installation process is completely GUI-free other than accepting the license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) compiler/runtime Issues related to the Go compiler and/or runtime. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
Status: Planned
Development

No branches or pull requests

7 participants