Skip to content

x/website: go1.20 docs refer to strings.Clone as new #58234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benpbrown opened this issue Feb 2, 2023 · 3 comments
Closed

x/website: go1.20 docs refer to strings.Clone as new #58234

benpbrown opened this issue Feb 2, 2023 · 3 comments
Assignees
@mknyszek
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Go1.20

Comments

@benpbrown
Copy link

What did you do?

Visited https://go.dev/doc/go1.20

What did you expect to see?

No reference to strings.Clone as being new. I believe it was introduced in Go 1.18 for strings (https://go.dev/doc/go1.18) (but in 1.20 for bytes 🙂 )

What did you see instead?

The following reference to a new function: The new [Clone](https://go.dev/pkg/strings/#Clone) function allocates a copy of a string.
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Feb 2, 2023
@mknyszek mknyszek modified the milestones: Go1.21, Unreleased Feb 2, 2023
@mknyszek mknyszek changed the title doc: go1.20 docs refer to strings.Clone as new x/website: go1.20 docs refer to strings.Clone as new Feb 2, 2023
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 2, 2023
@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2023

Ah, that's probably a copy-paste error, looking at the rest of the content of each section.

@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2023

I'll send out a CL.

@mknyszek mknyszek self-assigned this Feb 2, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/464775 mentions this issue: _content/doc: remove strings.Clone from Go 1.20 release notes.

@dmitshur dmitshur modified the milestones: Unreleased, Go1.20 Aug 3, 2023
@golang golang locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mknyszek mknyszek

Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @benpbrown @gopherbot